chore: migrate FollowArtist icon#74
Merged
Merged
Conversation
Member
Author
|
Is this really all that's required, and the build process takes care of the rest? |
Member
|
Yep! Looks good. I'll sometimes run the docs locally to ensure it builds correctly but that's optional |
MrSltun
approved these changes
May 5, 2025
MrSltun
left a comment
MrSltun
left a comment
Member
There was a problem hiding this comment.
Looks great! 🌟 Thank you Roop!
Member
Author
|
Good tip to run the docs. Yeah looks good, merging! |
Contributor
|
🚀 PR was released in |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://artsyproduct.atlassian.net/browse/MOPRAT-848
Copies the
FollowArtistIconfrom palette-mobile into artsy/icons.FollowArtistnaming (noIcon) to follow local naming patternsLet me know if I've missed something!