You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a new icon ArrowheadUpCircleFillIcon, renamed from ArrowUpCircleFillIcon, so that it's not confused with the current Arrow icons we currently have in Artsy Icons (arrow icons in Palette Mobile are chevron icons in Artsy Icons)
We've lost the "circle" concept from the name — do you think ArrowheadUpFilledCircleIcon is too verbose?
I don't think it's too verbose, I just mistakenly missed it 😅
I would suggest going with ArrowheadUpCircleFillIcon (after checking what we have in Artsy Icons), what do you think?
ArrowheadUpCircleFillIcon is good. Adheres to adjective order better :) (Determiner Opinion Size Age Shape Color Origin Material and Purpose) (Shape before color/style)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves MOPRAT-841
Description
This PR adds a new icon
ArrowheadUpCircleFillIcon, renamed fromArrowUpCircleFillIcon, so that it's not confused with the current Arrow icons we currently have in Artsy Icons (arrow icons in Palette Mobile are chevron icons in Artsy Icons)But I'm open to different naming for the icon
New Icon