Skip to content

ci(audit-self): wire 4 present-but-unwired install-sh tests + meta-gate — GH #531 audit follow-up - #545

Merged
artyhoo merged 1 commit into
stagingfrom
fix/audit-self-wire-missing-install-sh-tests
Jun 16, 2026
Merged

ci(audit-self): wire 4 present-but-unwired install-sh tests + meta-gate — GH #531 audit follow-up#545
artyhoo merged 1 commit into
stagingfrom
fix/audit-self-wire-missing-install-sh-tests

Conversation

@artyhoo

@artyhoo artyhoo commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Summary

The #531 audit (this session) surfaced 4 install-sh test files that exist but were never invoked by CI — the armed-but-not-fired anti-pattern. A test wired at no channel fails at none, which contradicts the project's "every rule fails at the earliest reachable channel" thesis. Same class as #540 shipping gh-531's test unwired (fixed in #543).

Closes MAJOR-2 (second half) + recommendation #3 from the audit.

Changes (2 files)

  • .github/workflows/audit-self.yml — wire the 4 tests as deterministic bash steps (no paid-LLM; compliant with no-paid-llm-in-ci.md):
    • gh-534-arch-boundaries.test.sh
    • gh-535-rule-enforced.test.sh
    • c1-wiring.test.sh
    • ship-orchestration-skills.test.sh
  • tests/install-sh/meta-all-wired.test.sh (new) — a meta-gate asserting every tests/install-sh/*.test.sh is wired in audit-self.yml, so this omission can't reland silently. Non-vacuous NEG (removing a wiring from a workflow copy flips the gate). Wired itself → 33/33 install-sh test files now invoked in CI.

Verification

Scope notes

Prior-art: skipped — CI wiring + a deterministic meta-gate test, no new capability.

…te — GH #531 audit follow-up

The #531 audit found 4 install-sh test files that exist but were never invoked by
CI (armed-but-not-fired): gh-534-arch-boundaries, gh-535-rule-enforced, c1-wiring,
ship-orchestration-skills. A test wired at NO channel is a false-green — it fails
at none, contradicting the project's "fail at the earliest reachable channel"
thesis. Same class as #540 shipping gh-531's test unwired (fixed in #543).

- audit-self.yml: wire the 4 tests as deterministic bash steps (all pass locally;
  no paid-LLM — compliant with no-paid-llm-in-ci.md).
- tests/install-sh/meta-all-wired.test.sh (new): a meta-gate asserting EVERY
  tests/install-sh/*.test.sh is wired in audit-self.yml, so this omission cannot
  reland silently. Non-vacuous NEG (removing a wiring from a workflow copy flips
  the gate). Wired itself (33/33 test files now invoked in CI).

Prior-art: skipped — CI wiring + a deterministic meta-gate test, no new capability.
@artyhoo
artyhoo enabled auto-merge (squash) June 16, 2026 07:39
@artyhoo
artyhoo merged commit 3f872df into staging Jun 16, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant