fix(agents+install): valid CC sub-agent tool names (#551) + exclude authoring-only prober (#552) - #571
Merged
Conversation
…uthoring-only prober from consumer payload (#552)
artyhoo
enabled auto-merge (squash)
June 16, 2026 18:31
artyhoo
added a commit
that referenced
this pull request
Jun 16, 2026
…k-guard (#574) - agents-toolname-fix-551-552-meta-launch/kickoff.md: /pipeline meta-launch dispatch record (routing fix→DIRECT/Mode-A, §1.7 PR-body mandate, principle-12 green). - agents-toolname-fix-551-552/kickoff.md: add §4c park-don't-guess block so autonomous aif-handoff dispatch cannot silently guess design forks. The #551/#552 code fix itself ships separately in PR #571.
artyhoo
added a commit
that referenced
this pull request
Jun 16, 2026
…551 regression-prevention) Phase 1 of shipped-artifact-liveness-gap (research PR #566, Option C phased, scope (i)). The 6 agents themselves were already fixed on staging by #571; this adds the DETERMINISTIC GATE #571 did not — preventing any future non-canonical tool name from shipping (the form-check that would have caught #551 at pre-push/CI). - packages/core/principles/21-shipped-agent-tools-valid.test.ts (9 tests, paired-negative arm) - prior-art-evaluations.md #121 (BUILD; own liveness family with #114/#115) Built autonomously via aif-handoff (task 8cae6079); agent edits dropped as redundant with #571. Prior-art: prior-art-evaluations.md#121 (BUILD - shipped-agent tools:-name allow-list gate; no upstream validator; own liveness family with #114/#115; T16 form-check distinct from #53/#115 behavioural eval).
artyhoo
added a commit
that referenced
this pull request
Jun 16, 2026
…551 regression-prevention) Phase 1 of shipped-artifact-liveness-gap (research PR #566, Option C phased, scope (i)). The 6 agents were already fixed on staging by #571; this adds the DETERMINISTIC GATE #571 did not — preventing any future non-canonical tool name from shipping. - packages/core/principles/21-shipped-agent-tools-valid.test.ts (9 tests, paired-negative) - prior-art-evaluations.md #121 (BUILD; own liveness family with #114/#115) Built autonomously via aif-handoff (task 8cae6079); agent edits dropped as redundant with #571. §1.7: forward-check applied — no-paid-llm-in-ci compliant (deterministic vitest, zero API call), build-first-reuse BUILD #121 (no upstream validator), T16 form-check not behaviour-check; backward-check sweep — #571 already made the 6 agents canonical so this adds only the missing regression gate and supersedes nothing. Evidence: packages/core/principles/21-shipped-agent-tools-valid.test.ts:46 Prior-art: prior-art-evaluations.md#121 (BUILD - shipped-agent tools:-name allow-list gate; no upstream validator; own liveness family with #114/#115; T16 form-check distinct from #53/#115 behavioural eval).
artyhoo
added a commit
that referenced
this pull request
Jun 16, 2026
…551 regression-prevention) (#576) Phase 1 of shipped-artifact-liveness-gap (research PR #566, Option C phased, scope (i)). The 6 agents were already fixed on staging by #571; this adds the DETERMINISTIC GATE #571 did not — preventing any future non-canonical tool name from shipping. - packages/core/principles/21-shipped-agent-tools-valid.test.ts (9 tests, paired-negative) - prior-art-evaluations.md #121 (BUILD; own liveness family with #114/#115) Built autonomously via aif-handoff (task 8cae6079); agent edits dropped as redundant with #571. §1.7: forward-check applied — no-paid-llm-in-ci compliant (deterministic vitest, zero API call), build-first-reuse BUILD #121 (no upstream validator), T16 form-check not behaviour-check; backward-check sweep — #571 already made the 6 agents canonical so this adds only the missing regression gate and supersedes nothing. Evidence: packages/core/principles/21-shipped-agent-tools-valid.test.ts:46 Prior-art: prior-art-evaluations.md#121 (BUILD - shipped-agent tools:-name allow-list gate; no upstream validator; own liveness family with #114/#115; T16 form-check distinct from #53/#115 behavioural eval).
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #551 and #552. Built autonomously by aif-handoff (task
8a523805); harvested via the GitHub Git Data API (container git transport was blocked by a missing-actionlintpre-push hook).tools:names (read_file/list_files/run_command) → empty toolset → the agent fabricates. Corrected to valid CC names per each agent's actual needs (Read, Glob, Grep/Read, Glob, Bashfor living-docs /Read, Glob, Grep, Agentfor the prober /Readfor worker-discipline).manual-rule-liveness-proberis an authoring-only tool (reads framework-internal paths, architecturally needs top-levelclaude --agent) → excluded from the consumer payload via aninstall.shglob case-skip, kept in source.SHIPPED_DOCS↔REQUIRED_HEADER_DOCSswapped toorchestrator-worker-discipline.md(keeps count 18 and set-equal — the line-139 gate).§1.7 Forward-check applied
Checked this change against existing disciplines before shipping:
doc-authority-hierarchy.md— theSHIPPED_DOCS↔REQUIRED_HEADER_DOCSswap keeps the shipped-subset count at 18 and set-equal, satisfying the assertion atpackages/core/principles/09-doc-authority-hierarchy.ts:139.build-first-reuse-default.md— fix matches upstream AI Factory CC naming (ADOPT, not BUILD); thetools:line corrected atagents/compliance-verifier.md:4.no-paid-llm-in-ci.md— no API-billed path introduced; verdict OK.§1.7 Backward-check applied
Swept the existing artefacts under this change's scope:
agents/manual-rule-liveness-prober.md— excluded from the consumer payload, kept in source as an authoring tool; itstools:line corrected atagents/manual-rule-liveness-prober.md:4.agents/orchestrator-worker-discipline.md— added toSHIPPED_DOCS(was missing = bug manual-rule-liveness-prober is shipped to consumers but DOA: reads framework-internal paths (rules-manifest.json/preset RULES/integration-rules) not in the install, and lacks the Task tool to dispatch #552-C);tools:line atagents/orchestrator-worker-discipline.md:4.🤖 Autonomous build via aif-handoff, harvested via gh API.