Chat Lane Settlement -> Primary

[arul28]

  Open in ADE  ·  ade/chat-lane-settlement branch  ·  PR #1051

Summary by CodeRabbit

• New Features

  • Automatically settles eligible linked sessions when their pull request is merged, including sessions with background activity.
  • Pull request processing now consistently evaluates merge settlements.
  • Improved recognition of older or incomplete chat session states, including idle and waiting-for-input statuses.

• Bug Fixes

  • Prevented duplicate settlements and ensured disabled auto-settlement remains inactive.
  • Unsupported shell sessions continue to be excluded from automatic settlement.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
ade	Ignored	Preview	Aug 6, 2026 7:53pm

[coderabbitai]

Warning

Review limit reached

@arul28, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 219c53b3-3e15-4daf-83ab-dd5f3345aa28

📥 Commits

Reviewing files that changed from the base of the PR and between c04fa32 and badd459.

📒 Files selected for processing (1)

• apps/desktop/src/renderer/state/crossMachineLanes.test.ts

📝 Walkthrough

Walkthrough

Changes

PR merge auto-settlement

Layer / File(s)	Summary
Unconditional PR merge settlement apps/desktop/src/main/services/prs/prMergeAutoSettlementService.ts, apps/desktop/src/main/main.ts, apps/ade-cli/src/bootstrap.ts	PR merges settle eligible linked sessions without blocker checks. Runtime setup always creates and invokes the settlement service.
Settlement lifecycle validation apps/desktop/src/main/services/prs/prAsync.test.ts	Tests cover session eligibility, one settlement per PR, later merged PRs, and disabled auto-settlement.

Foreign session runtime state

Layer / File(s)	Summary
Foreign chat state normalization apps/desktop/src/renderer/state/crossMachineLanes.ts, apps/desktop/src/renderer/state/crossMachineLanes.test.ts	Foreign chat sessions without runtime state decode as idle or waiting-input. Explicit runtime states and non-chat sessions retain their existing behavior.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• arul28/ADE#886: Both changes modify PR merge auto-settlement and session lifecycle handling.
• arul28/ADE#951: Both changes modify prMergeAutoSettlementService and PR merge settlement behavior.
• arul28/ADE#973: Both changes modify session-settlement lifecycle behavior.

Suggested labels: desktop, docs

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references chat lane settlement, which matches a major change in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ade/chat-lane-settlement

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

apps/desktop/src/renderer/state/crossMachineLanes.test.ts (1)

1005-1010: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Test stale active-turn timing in the fallback path.

The quiet fixture omits currentTurnStartedAt. The null assertion passes even if the decoder stops clearing a stale remote timestamp. Add a non-null timestamp to this fixture and keep the expected value as null.

Proposed test update

       {
         id: "chat-quiet",
         laneId: "lane-1",
         status: "running",
         toolType: "claude-chat",
+        currentTurnStartedAt: "2026-08-06T12:00:00.000Z",
       },

As per coding guidelines, “Record a named regression test or exact alternate verification for every accepted correctness finding.”

Also applies to: 1033-1037

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/desktop/src/renderer/state/crossMachineLanes.test.ts` around lines 1005
- 1010, Update the “quiet” fixture in the fallback-path regression test to
include a non-null currentTurnStartedAt timestamp while retaining the expected
decoded value of null. Apply the same fixture change to the additional case
around the related assertion so the tests verify stale remote timestamps are
cleared.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@apps/desktop/src/renderer/state/crossMachineLanes.test.ts`:
- Around line 1005-1010: Update the “quiet” fixture in the fallback-path
regression test to include a non-null currentTurnStartedAt timestamp while
retaining the expected decoded value of null. Apply the same fixture change to
the additional case around the related assertion so the tests verify stale
remote timestamps are cleared.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d227133-d14e-44ec-8ea4-f427c7bcba07

📥 Commits

Reviewing files that changed from the base of the PR and between 1dff14f and c04fa32.

⛔ Files ignored due to path filters (1)

• docs/features/pull-requests/README.md is excluded by !docs/**

📒 Files selected for processing (6)

• apps/ade-cli/src/bootstrap.ts
• apps/desktop/src/main/main.ts
• apps/desktop/src/main/services/prs/prAsync.test.ts
• apps/desktop/src/main/services/prs/prMergeAutoSettlementService.ts
• apps/desktop/src/renderer/state/crossMachineLanes.test.ts
• apps/desktop/src/renderer/state/crossMachineLanes.ts

💤 Files with no reviewable changes (1)

• apps/desktop/src/main/main.ts

[arul28]

@codex review

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.