fix(ios): keep Work chat on-screen when the keyboard opens - #1198
Merged
Conversation
Opening the composer or system keyboard shrank the transcript window without re-gluing a following viewport, and could overscroll a reading position into blank space. Re-pin the live tail across window and card collapse the same way terminals already do; restore a scrolled-up offset instead of yanking to latest. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reachedNext included review available in 52 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening the composer or the system keyboard on ADE Mobile shrinks the Work-chat window. A following transcript could leave the newest lines cropped below that shorter window, and a finishing turn that collapsed cards could overscroll into blank space. A reader who had scrolled up could also lose their place.
Cause
Keyboard avoidance reports as SwiftUI
.interacting, which dropped live-follow and blocked the pin write. After the opening bottom pin disarmed (~600ms), the content-size observer did not re-glue the way CLI terminals already re-assert the live tail on layout.Change and boundary
Work chat (including personal chats on the same SwiftUI view) now re-pins a following viewport across keyboard/composer shrink, keyboard hide, and card collapse, and restores a scrolled-up offset clamped to the new range. Keyboard
.interactingis not treated as the reader taking over.Deliberately unchanged: weak-connection subscribe/hydration freeze, desktop/CLI/web chat, and any port of pingdotgg/t3code#9013 (that list is React Native; ADE iOS is native SwiftUI).
Verification
ADETestslayout-pin cases on iPhone 17 Pro simulator, all passed (testFollowingViewportShrinkPinsToLatest,testFollowingViewportGrowPinsToLatest, inset-only window change, history restore/clamp, content shrink/growth, fling deferral, keyboard phase vs real scroll, reclaim-at-tail)./qualitydual-track review: gate empty after two fix/re-review passes./test: logging not applicable (high-frequency scroll layout); docs already current inios-companion.md; CLI/TUI/SDK not applicable.Authored with Cursor Grok 4.6 via ADE.