Automatic Lane Naming -> Primary - #977
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughChangesADE status, chat lifecycle, lane updates, and GitHub authentication
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af1888c69c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e7d688df6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3e7d688 to
ab62838
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
🧹 Nitpick comments (1)
apps/desktop/src/renderer/components/settings/GitHubSection.tsx (1)
38-46: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winReuse
REQUIRED_GITHUB_REPOSITORY_PERMISSIONSin the error copy.The constant now includes
Checks: Read and writeandCommit statuses: Read. Two error messages in this file still list only Contents, Pull requests, Metadata, Actions, and Workflows (thehandleSaveTokenmessage and therepoProbeFailedmessage). The lists can drift further. Derive both messages from this constant.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/desktop/src/renderer/components/settings/GitHubSection.tsx` around lines 38 - 46, Update the handleSaveToken and repoProbeFailed error messages in GitHubSection to derive their permission lists from REQUIRED_GITHUB_REPOSITORY_PERMISSIONS instead of duplicating hardcoded entries. Preserve the existing message context while ensuring both messages include every permission currently defined by the constant.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/ade-cli/src/cli.ts`:
- Line 1721: Separate the example command from its explanatory description in
the CLI help text near the chat note example. Move the description to its own
line or prefix it with the surrounding comment marker so it cannot be
interpreted as additional ade chat note arguments.
In `@apps/ade-cli/src/headlessLinearServices.test.ts`:
- Around line 672-677: Prevent inherited GitHub environment tokens from
affecting both new credential tests. In
apps/ade-cli/src/headlessLinearServices.test.ts at lines 672-677, capture and
delete ADE_GITHUB_TOKEN, GITHUB_TOKEN, and GH_TOKEN before creating the service,
then restore them in the existing finally block; apply the same handling at
lines 729-742 alongside GH_CONFIG_DIR and ADE_DISABLE_GH_AUTH_FALLBACK,
restoring each original value in that test’s finally block.
In `@apps/ade-cli/src/headlessLinearServices.ts`:
- Around line 592-603: Preserve the GitHub CLI metadata when the PAT resolver
wins: update the `pat` resolver in the lookup and the corresponding
`readTokenAsync` path to merge the previously observed `ghCliPath` and
`ghAuthError` from `ghAuthToken()` into the PAT result instead of resetting them
to null. Keep the PAT token and source fields unchanged while ensuring
`getStatus` can report CLI diagnostics after a PAT fallback.
In `@apps/desktop/resources/agent-skills/ade-cli-control-plane/SKILL.md`:
- Around line 193-195: Update the status-note guidance in
apps/desktop/resources/agent-skills/ade-cli-control-plane/SKILL.md:193-195 to
state the 3–6-word and 72-character limits. Update the corresponding source help
definition in apps/desktop/resources/ade-cli-help.txt:605 to include both
limits, then regenerate the help digest so it matches.
In `@apps/desktop/src/main/services/chat/agentChatService.ts`:
- Around line 35516-35556: Update steerUserMessage and its steerWithOptions
dispatch flow so idle OpenCode, Cursor, and Droid sessions resolve immediately
once the steer is accepted and its dispatched steer id is available, without
awaiting executePreparedSendMessage or the full turn. Clear turn-start markers
after acceptance, while preserving existing queue-full and non-idle behavior.
- Around line 35519-35530: Update waitsForProviderDispatch to narrow
managed.runtime by its kind before accessing busy, following the existing
canRouteActiveSendToSteer pattern. Ensure the check only reads busy on runtime
variants that declare it while preserving the current provider, busy, and
session-status conditions.
In `@apps/desktop/src/main/services/github/githubService.ts`:
- Around line 716-724: The CLI credential selectors report an incorrect
patTokenStored value for environment and gh sources. In
apps/ade-cli/src/headlessLinearServices.ts lines 585-603 and 626-644, update the
environment and gh branches of readToken and readTokenAsync to return the actual
stored-PAT state, matching the reference behavior in
apps/desktop/src/main/services/github/githubService.ts lines 716-724; no direct
change is required at the desktop site.
In `@apps/desktop/src/main/services/lanes/laneService.ts`:
- Around line 6666-6674: Emit the lane-branch-updated lifecycle event from every
path that changes lanes.branch_ref, specifically the branch-ref updates in
switchBranch and the keep-head path of resolveBranchDrift. Reuse the existing
lane lookup and event payload pattern shown here, while preserving any existing
lane-renamed emission.
In `@apps/desktop/src/renderer/components/chat/AgentChatPane.tsx`:
- Around line 10165-10170: Update the failed dispatch catch path in the
send/steer flow to reconcile the optimistic changes made by touchSession and
activeTurnSessionSummaryPatch: after dispatch failure, refresh the session
summary or restore its prior state so the session is not left active with a
stale currentTurnStartedAt, while preserving the existing composer restoration.
In `@apps/desktop/src/renderer/components/terminals/LaneNamingLabel.tsx`:
- Around line 11-17: Update the naming indicator in LaneNamingLabel so its
"Naming lane…" label is exposed through a valid accessible role: use
role="status" on the live indicator, or provide equivalent visually hidden
accessible text while removing the unsupported aria-label from the span. Verify
the resulting accessibility tree in Chromium/Electron.
In `@apps/desktop/src/shared/adeCliGuidance.test.ts`:
- Around line 64-82: Add the 72-character status-note limit string to the
invariant list in the test case “keeps the bundled control-plane skill aligned
with the bootstrap lifecycle contract,” ensuring both bootstrap guidance and
SKILL.md are checked for this requirement alongside the existing lifecycle
phrases.
In `@apps/desktop/src/shared/sessionStatusNote.ts`:
- Around line 16-19: Update the word-based truncation in the status-note
formatting logic to reserve one character for the ellipsis, ensuring any result
produced when additional words exist remains within MAX_STATUS_NOTE_CHARACTERS.
Preserve the existing character-based truncation and untruncated wordSummary
behavior.
---
Nitpick comments:
In `@apps/desktop/src/renderer/components/settings/GitHubSection.tsx`:
- Around line 38-46: Update the handleSaveToken and repoProbeFailed error
messages in GitHubSection to derive their permission lists from
REQUIRED_GITHUB_REPOSITORY_PERMISSIONS instead of duplicating hardcoded entries.
Preserve the existing message context while ensuring both messages include every
permission currently defined by the constant.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: b338a776-155d-41da-9372-b3164d6303a9
⛔ Files ignored due to path filters (8)
CHANGELOG.mdis excluded by!*.mddocs/features/agents/README.mdis excluded by!docs/**docs/features/chat/README.mdis excluded by!docs/**docs/features/chat/composer-and-ui.mdis excluded by!docs/**docs/features/lanes/README.mdis excluded by!docs/**docs/features/onboarding-and-settings/README.mdis excluded by!docs/**docs/features/terminals-and-sessions/README.mdis excluded by!docs/**docs/features/terminals-and-sessions/ui-surfaces.mdis excluded by!docs/**
📒 Files selected for processing (50)
apps/ade-cli/README.mdapps/ade-cli/src/cli.tsapps/ade-cli/src/headlessLinearServices.test.tsapps/ade-cli/src/headlessLinearServices.tsapps/ade-cli/src/services/sync/rosterBuilder.test.tsapps/ade-cli/src/services/sync/rosterBuilder.tsapps/ade-cli/src/services/sync/syncRemoteCommandService.test.tsapps/ade-cli/src/services/sync/syncRemoteCommandService.tsapps/ade-cli/src/tuiClient/__tests__/appPolling.test.tsxapps/ade-cli/src/tuiClient/app.tsxapps/ade-cli/src/tuiClient/remoteLauncher.tsapps/desktop/resources/ade-cli-help.txtapps/desktop/resources/agent-skills/ade-cli-control-plane/SKILL.mdapps/desktop/src/main/services/ai/tools/orchestrationTools.test.tsapps/desktop/src/main/services/ai/tools/systemPrompt.test.tsapps/desktop/src/main/services/chat/agentChatService.test.tsapps/desktop/src/main/services/chat/agentChatService.tsapps/desktop/src/main/services/chat/cursorSdkSystemPrompt.test.tsapps/desktop/src/main/services/github/githubService.test.tsapps/desktop/src/main/services/github/githubService.tsapps/desktop/src/main/services/ipc/registerIpc.tsapps/desktop/src/main/services/lanes/laneService.test.tsapps/desktop/src/main/services/lanes/laneService.tsapps/desktop/src/main/services/sessions/chatSessionProjection.tsapps/desktop/src/main/services/sessions/sessionService.test.tsapps/desktop/src/main/services/sessions/sessionService.tsapps/desktop/src/main/services/sync/syncRemoteCommandService.test.tsapps/desktop/src/renderer/components/app/toast/useLaneEventToasts.tsapps/desktop/src/renderer/components/chat/AgentChatPane.test.tsxapps/desktop/src/renderer/components/chat/AgentChatPane.tsxapps/desktop/src/renderer/components/github/GitHubAppInstallPanel.tsxapps/desktop/src/renderer/components/settings/GitHubSection.tsxapps/desktop/src/renderer/components/terminals/LaneNamingLabel.tsxapps/desktop/src/renderer/components/terminals/SessionCard.test.tsxapps/desktop/src/renderer/components/terminals/SessionCard.tsxapps/desktop/src/renderer/components/terminals/SessionListPane.test.tsxapps/desktop/src/renderer/components/terminals/SessionListPane.tsxapps/desktop/src/renderer/components/terminals/SessionStatusSlot.tsxapps/desktop/src/renderer/index.cssapps/desktop/src/renderer/lib/githubIntegrationStatus.test.tsapps/desktop/src/renderer/lib/githubIntegrationStatus.tsapps/desktop/src/renderer/lib/sessions.tsapps/desktop/src/renderer/state/laneNamingStore.tsapps/desktop/src/shared/adeCliGuidance.test.tsapps/desktop/src/shared/adeCliGuidance.tsapps/desktop/src/shared/githubOperationCredential.tsapps/desktop/src/shared/sessionStatusNote.tsapps/desktop/src/shared/types/chat.tsapps/desktop/src/shared/types/lanes.tsapps/desktop/src/shared/types/sessions.ts
3930a57 to
3d1e54c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d1e54c301
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b57ef7823
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e61031d93a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/ade-cli/src/adeRpcServer.test.ts (1)
2332-2332: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAssert that
createCallexists before checking its environment.
createCallcomes frommock.calls.at(-1)?.[0], so the assertion can pass when noptyService.createcall exists. Add an explicitexpect(createCall).toBeDefined();beforecreateCall?.env.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/ade-cli/src/adeRpcServer.test.ts` at line 2332, In the test assertion around createCall, first assert that createCall is defined, then check its env does not contain ADE_BUNDLED_AGENT_SKILLS_DIR_ENV. Remove the optional chaining from the environment assertion so the test cannot pass when no ptyService.create call was recorded.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/ade-cli/src/headlessLinearServices.test.ts`:
- Around line 674-682: The test setup stores and clears environment tokens but
does not isolate GH_CONFIG_DIR, allowing the host's GitHub CLI credentials to
interfere with the test. Add a store of the previous GH_CONFIG_DIR value
alongside the other previousX variables, set process.env.GH_CONFIG_DIR to a new
temporary directory using fs.mkdtempSync with a unique name pattern (matching
the ADE_HOME pattern), and restore it in the finally block along with the other
restored environment variables.
---
Outside diff comments:
In `@apps/ade-cli/src/adeRpcServer.test.ts`:
- Line 2332: In the test assertion around createCall, first assert that
createCall is defined, then check its env does not contain
ADE_BUNDLED_AGENT_SKILLS_DIR_ENV. Remove the optional chaining from the
environment assertion so the test cannot pass when no ptyService.create call was
recorded.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 0fa64d45-c539-49cc-b423-b3d81121a11d
⛔ Files ignored due to path filters (8)
CHANGELOG.mdis excluded by!*.mddocs/features/agents/README.mdis excluded by!docs/**docs/features/chat/README.mdis excluded by!docs/**docs/features/chat/composer-and-ui.mdis excluded by!docs/**docs/features/lanes/README.mdis excluded by!docs/**docs/features/onboarding-and-settings/README.mdis excluded by!docs/**docs/features/terminals-and-sessions/README.mdis excluded by!docs/**docs/features/terminals-and-sessions/ui-surfaces.mdis excluded by!docs/**
📒 Files selected for processing (55)
apps/ade-cli/README.mdapps/ade-cli/src/adeRpcServer.test.tsapps/ade-cli/src/cli.tsapps/ade-cli/src/headlessLinearServices.test.tsapps/ade-cli/src/headlessLinearServices.tsapps/ade-cli/src/services/sync/rosterBuilder.test.tsapps/ade-cli/src/services/sync/rosterBuilder.tsapps/ade-cli/src/services/sync/syncRemoteCommandService.test.tsapps/ade-cli/src/services/sync/syncRemoteCommandService.tsapps/ade-cli/src/tuiClient/__tests__/appPolling.test.tsxapps/ade-cli/src/tuiClient/app.tsxapps/ade-cli/src/tuiClient/remoteLauncher.tsapps/desktop/resources/ade-cli-help.txtapps/desktop/resources/agent-skills/ade-cli-control-plane/SKILL.mdapps/desktop/src/main/services/adeActions/registry.test.tsapps/desktop/src/main/services/adeActions/registry.tsapps/desktop/src/main/services/ai/tools/orchestrationTools.test.tsapps/desktop/src/main/services/ai/tools/systemPrompt.test.tsapps/desktop/src/main/services/chat/agentChatService.test.tsapps/desktop/src/main/services/chat/agentChatService.tsapps/desktop/src/main/services/chat/cursorSdkSystemPrompt.test.tsapps/desktop/src/main/services/github/githubService.test.tsapps/desktop/src/main/services/github/githubService.tsapps/desktop/src/main/services/ipc/registerIpc.tsapps/desktop/src/main/services/ipc/runtimeBridge.test.tsapps/desktop/src/main/services/lanes/laneService.test.tsapps/desktop/src/main/services/lanes/laneService.tsapps/desktop/src/main/services/sessions/chatSessionProjection.tsapps/desktop/src/main/services/sessions/sessionService.test.tsapps/desktop/src/main/services/sessions/sessionService.tsapps/desktop/src/main/services/sync/syncRemoteCommandService.test.tsapps/desktop/src/renderer/components/app/toast/useLaneEventToasts.tsapps/desktop/src/renderer/components/chat/AgentChatPane.test.tsxapps/desktop/src/renderer/components/chat/AgentChatPane.tsxapps/desktop/src/renderer/components/github/GitHubAppInstallPanel.tsxapps/desktop/src/renderer/components/settings/GitHubSection.tsxapps/desktop/src/renderer/components/terminals/LaneNamingLabel.tsxapps/desktop/src/renderer/components/terminals/SessionCard.test.tsxapps/desktop/src/renderer/components/terminals/SessionCard.tsxapps/desktop/src/renderer/components/terminals/SessionListPane.test.tsxapps/desktop/src/renderer/components/terminals/SessionListPane.tsxapps/desktop/src/renderer/components/terminals/SessionStatusSlot.tsxapps/desktop/src/renderer/index.cssapps/desktop/src/renderer/lib/githubIntegrationStatus.test.tsapps/desktop/src/renderer/lib/githubIntegrationStatus.tsapps/desktop/src/renderer/lib/sessions.tsapps/desktop/src/renderer/state/laneNamingStore.tsapps/desktop/src/shared/adeCliGuidance.test.tsapps/desktop/src/shared/adeCliGuidance.tsapps/desktop/src/shared/githubOperationCredential.tsapps/desktop/src/shared/sessionStatusNote.test.tsapps/desktop/src/shared/sessionStatusNote.tsapps/desktop/src/shared/types/chat.tsapps/desktop/src/shared/types/lanes.tsapps/desktop/src/shared/types/sessions.ts
🚧 Files skipped from review as they are similar to previous changes (46)
- apps/ade-cli/src/tuiClient/remoteLauncher.ts
- apps/ade-cli/README.md
- apps/ade-cli/src/services/sync/rosterBuilder.ts
- apps/desktop/resources/ade-cli-help.txt
- apps/desktop/src/shared/types/sessions.ts
- apps/desktop/src/renderer/index.css
- apps/desktop/src/main/services/ai/tools/orchestrationTools.test.ts
- apps/desktop/src/main/services/ai/tools/systemPrompt.test.ts
- apps/desktop/src/main/services/sync/syncRemoteCommandService.test.ts
- apps/desktop/src/renderer/components/terminals/LaneNamingLabel.tsx
- apps/desktop/src/shared/sessionStatusNote.ts
- apps/desktop/src/main/services/ipc/registerIpc.ts
- apps/desktop/src/shared/adeCliGuidance.ts
- apps/desktop/src/renderer/components/terminals/SessionListPane.test.tsx
- apps/desktop/src/renderer/components/github/GitHubAppInstallPanel.tsx
- apps/desktop/src/renderer/lib/sessions.ts
- apps/desktop/src/renderer/state/laneNamingStore.ts
- apps/desktop/src/shared/types/lanes.ts
- apps/ade-cli/src/services/sync/syncRemoteCommandService.test.ts
- apps/ade-cli/src/cli.ts
- apps/ade-cli/src/tuiClient/tests/appPolling.test.tsx
- apps/desktop/src/main/services/lanes/laneService.ts
- apps/desktop/src/renderer/components/terminals/SessionStatusSlot.tsx
- apps/desktop/src/renderer/lib/githubIntegrationStatus.test.ts
- apps/ade-cli/src/services/sync/syncRemoteCommandService.ts
- apps/desktop/src/shared/types/chat.ts
- apps/desktop/src/renderer/components/terminals/SessionCard.test.tsx
- apps/desktop/src/shared/githubOperationCredential.ts
- apps/desktop/src/renderer/components/chat/AgentChatPane.test.tsx
- apps/desktop/src/renderer/lib/githubIntegrationStatus.ts
- apps/ade-cli/src/services/sync/rosterBuilder.test.ts
- apps/desktop/src/main/services/sessions/sessionService.test.ts
- apps/desktop/src/main/services/chat/cursorSdkSystemPrompt.test.ts
- apps/desktop/src/renderer/components/terminals/SessionListPane.tsx
- apps/ade-cli/src/tuiClient/app.tsx
- apps/desktop/src/main/services/github/githubService.ts
- apps/desktop/src/main/services/lanes/laneService.test.ts
- apps/desktop/resources/agent-skills/ade-cli-control-plane/SKILL.md
- apps/desktop/src/renderer/components/terminals/SessionCard.tsx
- apps/desktop/src/main/services/sessions/chatSessionProjection.ts
- apps/desktop/src/main/services/sessions/sessionService.ts
- apps/desktop/src/renderer/components/chat/AgentChatPane.tsx
- apps/desktop/src/renderer/components/settings/GitHubSection.tsx
- apps/desktop/src/renderer/components/app/toast/useLaneEventToasts.ts
- apps/desktop/src/main/services/github/githubService.test.ts
- apps/ade-cli/src/headlessLinearServices.ts
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb8fa83beb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| && result.reason !== "queue_full" | ||
| && !args.metadata?.scheduledWake | ||
| && (!waitsForProviderDispatch || markersCleared) | ||
| ) { | ||
| clearAcceptedUserMarkers(); |
There was a problem hiding this comment.
When a user answers a busy Droid chat with only a file or image, Droid's active-turn branch calls prepareSendMessage with attachments: [], so preparation returns null and no steer is queued. This condition nevertheless treats the resulting { queued: false } as accepted and clears the turn-start/attention markers, making the Needs you hand-raise disappear even though the attachment never reached the provider; only clear markers after preparation or queueing confirms acceptance.
Useful? React with 👍 / 👎.
1 participant
Summary by CodeRabbit
New Features
Documentation
Bug Fixes