Conversation
[fixes] Fixes from dev
…eat/bundler-service
…eat/bundler-service
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #90 +/- ##
===========================================
+ Coverage 41.64% 54.19% +12.55%
===========================================
Files 25 48 +23
Lines 3607 10566 +6959
===========================================
+ Hits 1502 5726 +4224
- Misses 2105 4840 +2735
☔ View full report in Codecov by Sentry. |
das-Abroxas
approved these changes
Jul 3, 2023
Contributor
das-Abroxas
left a comment
das-Abroxas
left a comment
There was a problem hiding this comment.
Again, too many changes for a meaningful review. We have to work on that.
But I tried my best and didn't see anything conspicious. LGTM.
| - "tests" # we also don't care about coverage of test code | ||
| - "benches" # or coverage of benchmarks | ||
| - "protos" # coverage for protos are not necessary either | ||
| - "migrations" # exclude database stuffnecessary either |
Contributor
There was a problem hiding this comment.
Suggested change
| - "migrations" # exclude database stuffnecessary either |
I don't think we need a duplicate exclusion?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the backend functionality of a "bundler" service.
This service is used to bundle multiple objects into downloadable packages. This is done by xor'ing all relevant object_ulids and collection_ids and afterwards signing the request with a server known secret. This ensures that bundle IDs cannot be guessed, but makes it so bundles containing the same objects will always have the same bundle ID.
Currently only .tar.gz archives are supported.
Changes
Fixes: #35