Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #91 +/- ##
==========================================
- Coverage 54.19% 52.18% -2.02%
==========================================
Files 48 49 +1
Lines 10566 10950 +384
==========================================
- Hits 5726 5714 -12
- Misses 4840 5236 +396
☔ View full report in Codecov by Sentry. |
das-Abroxas
approved these changes
Jul 3, 2023
Contributor
das-Abroxas
left a comment
There was a problem hiding this comment.
For me, it seems that the most important things have been taken into account, that service accounts cannot be abused. However, there is now a possibility for users that services can work with the AOS independently of personal accounts ✔️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of PR #90 . It adds the long awaited
ServiceAccountfeature.Service accounts are similar to regular users but have some restrictions:
Project::ADMINThis PR implements all necessary API and DB requests that make it possible to create, update and manage service accounts by Project Admins. The API should be treated as BETA for now.
The PR also adds some optimizations in the ApiToken <-> gRPC Token handling by introducing a
TryFromimplementation, this allows us to remove some token conversion boilerplate fromcrud/user.rsFixes: #38