Skip to content

bug: npm run lint only lints apps/web; core, cli, and action are never linted #70

Description

@aryamthecodebreaker

Summary

npm run lint reports success while linting only apps/web. The three published/shipped packages are never linted.

Root package.json:

"lint": "npm run lint --workspaces --if-present"

Only apps/web/package.json declares a lint script. packages/core, packages/cli, and packages/action declare build, test, and typecheck — no lint, and no ESLint config file exists under packages/.

Reproduction

npm run lint
> fixmap-workspace@0.5.0 lint
> npm run lint --workspaces --if-present

> @fixmap/web@0.0.0 lint
> eslint .

That is the entire output — --if-present silently skips the three packages.

Impact

npm run ci chains lint and the README states it "runs the complete test suite, typechecking, ESLint, production builds...". In reality ESLint never sees the scanner, ranker, CLI, MCP server, or the GitHub Action — i.e. all the code that actually ships to npm and the Actions marketplace. A green CI badge overstates the coverage.

Suggested fix

Add a shared flat ESLint config at the repo root (typescript-eslint) and a lint script to packages/core, packages/cli, and packages/action. Expect an initial cleanup pass; rules like no-floating-promises, no-unnecessary-condition, and consistent-type-imports are the useful ones for this codebase.

If linting the packages is intentionally out of scope for now, the README sentence should be corrected instead so npm run ci is not described as covering ESLint across the repo.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions