fix: Add missing @login_required to register view and fix HTTPError handling#613
Merged
Merged
Conversation
…andling - Register view was checking is_admin on AnonymousUser, causing AttributeError - Error handler tried to call non-existent .read() method on HTTPError from requests library - Now uses ex.response.text instead (proper requests HTTPError attribute) Tested on Python 3.12.12 and 3.13.3 - all imports successful
dahagag
force-pushed
the
fix/register-httperror-bugs
branch
from
fb129e0 to
14490d9
Compare
Extract filename from URL before passing to mimetypes.guess_type() since it only accepts filenames, not full URLs. This was causing images without Content-Type headers to fail base64 encoding, breaking offline functionality. Handles query strings correctly: http://example.com/image.png?size=large -> image.png
Ignore DL3013 warning for 'pip install --upgrade pip' since pinning pip version can cause issues with package installation. This is a known exception to the rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Comprehensive fixes for PR #613 addressing 3 test failures in CI and resolving critical bugs in Lokole 0.8.4.
Bug Fixes
1. Missing @login_required decorator on register view
is_adminonAnonymousUser, causingAttributeError: 'AnonymousUser' object has no attribute 'is_admin'opwen_email_client/webapp/views.py(line 288)@login_requireddecorator to ensure only authenticated users can access the registration form2. HTTPError handling uses non-existent .read() method
ex.read()onrequests.exceptions.HTTPError, but this method doesn't exist in therequestslibraryopwen_email_client/webapp/actions.pyex.response.textwhich is the correct way to access the response body from arequests.HTTPError3. Image type detection URL parsing bug (NEW)
_get_image_type()inemail_parser.pywas passing full URLs tomimetypes.guess_type(), which only accepts filenames. This caused images without Content-Type headers to fail base64 encoding, breaking offline email functionalityopwen_email_server/utils/email_parser.py(lines 145-149)mimetypes.guess_type(), properly handling query stringshttp://example.com/image.png?size=large→image.pngtest_format_inline_images_without_content_type,test_format_inline_images_with_query_string)4. Code formatting and linting
opwen_email_server/integration/cli.py- E127 continuation line indentation fixdocker/app/Dockerfile,docker/client/Dockerfile- Added hadolint ignore directives for unpinned pipTest Results
✅ All 237 unit tests PASS
CI Validation
✅ Hadolint (Dockerfile linting) - PASS
✅ Yamllint (YAML linting) - PASS
✅ Shellcheck (shell script linting) - PASS
✅ Helm lint (Kubernetes Helm charts) - PASS
✅ Kubeval (Kubernetes manifest validation) - PASS
Commits in This PR
78967ea- Add missing @login_required to register view and fix HTTPError handling14490d9- Fix continuation line indentation in cli.py027f7c3- Fix image type detection URL parsing in email_parser.py4fce07d- Add hadolint ignore directives for unpinned pip installFiles Modified
opwen_email_client/webapp/views.py- @login_required decoratoropwen_email_client/webapp/actions.py- HTTPError.response.text fixopwen_email_server/utils/email_parser.py- URL filename extraction fixopwen_email_server/integration/cli.py- E127 indentation fixdocker/app/Dockerfile- Hadolint ignore directivedocker/client/Dockerfile- Hadolint ignore directiveRelease Target
These fixes prepare Lokole 0.8.4 for Python 3.12+ compatibility with Flask 3.x, ensuring critical email offline functionality works correctly.