fix(pds): return 400 RecordNotFound and treat deleteRecord as no-op#189
Merged
Conversation
Match the reference @atproto PDS: getRecord raises InvalidRequestError (HTTP 400) with RecordNotFound, and deleteRecord on a missing record is a 200 no-op rather than an error. Adds a pdscheck for the getRecord status code.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
pdscheck | 20e8de5 | May 25 2026, 07:07 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
atproto-pds | 20e8de5 | May 25 2026, 07:07 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cirrusdocs | 20e8de5 | Commit Preview URL Branch Preview URL |
May 25 2026, 07:07 AM |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.atproto.repo.getRecordnow returns HTTP 400 withRecordNotFoundfor missing records (was 404). Matches the reference @atproto PDS, which raisesInvalidRequestError→ 400.com.atproto.repo.deleteRecordon a missing record is now a 200 no-op (empty body, no commit) instead ofRecordNotFound. Also matches the reference PDS.repo-read.get-record-missing) that verifies the 400 +RecordNotFoundresponse shape.Test plan
pnpm exec vitest run --config vitest.config.tsinpackages/pds— 302/302 pass.pnpm checkinapps/check— type-checks cleanly.