fix(pds): match reference PDS RecordNotFound message string#190
Merged
Conversation
The Bluesky social-app's quote-detach flow checks
e.message.includes('Could not locate record:') to decide whether to
create a new app.bsky.feed.postgate vs. update an existing one. Match
the reference @atproto PDS message verbatim so this flow works.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
pdscheck | b058fbe | May 25 2026, 08:47 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cirrusdocs | b058fbe | Commit Preview URL Branch Preview URL |
May 25 2026, 08:47 AM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
atproto-pds | b058fbe | May 25 2026, 08:47 AM |
commit: |
…not locate record:' The Bluesky social-app does a substring match on this phrase when detaching a quote (and similar create-vs-update flows). Add it to the existing repo-read.get-record-missing pdscheck so we catch any future regressions in PDS implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #189. The HTTP status code is now correct (400), but the Bluesky social-app's quote-detach flow does a string match on the response message:
```ts
// src/state/queries/postgate/index.ts (social-app)
if (e.message.includes(`Could not locate record:`)) {
return undefined // → fall through to createPostgateRecord
}
```
Our PDS was returning
Record not found: <collection>/<rkey>, so the social-app rethrew the error instead of creating the postgate. Match the reference @atproto PDS's exact phrasing —Could not locate record: at://<did>/<collection>/<rkey>.Test plan