feat(herald): add the Lore decisions-on-PR capability [roadmap:decisions-on-pr]#3
Merged
Merged
Conversation
tcballard
added a commit
to asdecided/core
that referenced
this pull request
Jul 18, 2026
… rac-ci [roadmap:decisions-on-pr] Implements rac/roadmaps/decisions-on-pr.md (epic #351): the Herald capability merged as asdecided/ci#3 — the advisory governing-decisions comment on pull requests, thin client over rac decisions-for --json, facts never a merge gate. Records the delivered answers to the design's three Open Questions and the v1-tag note (the tag predates Herald; consumers reference @main until a tag that includes it is cut).
tcballard
added a commit
to asdecided/core
that referenced
this pull request
Jul 18, 2026
… rac-ci [roadmap:decisions-on-pr] Implements rac/roadmaps/decisions-on-pr.md (epic #351): the Herald capability merged as asdecided/ci#3 — the advisory governing-decisions comment on pull requests, thin client over rac decisions-for --json, facts never a merge gate. Records the delivered answers to the design's three Open Questions and the v1-tag note (the tag predates Herald; consumers reference @main until a tag that includes it is cut).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivers the Herald capability — the decisions-on-PR advisory comment — implementing the
pr-decision-surfacingdesign and thedecisions-on-prroadmap in the rac-core corpus. Epic: itsthelore/rac-core#351.What it does
herald/github/action.ymlis a composite action, consumed asuses: itsthelore/rac-ci/herald/github@<ref>, that:fetch-depth: 0required, like Watchkeeper);rac decisions-for --jsonper changed path — the engine's live-decisions lookup (decision-to-code-proximity) — and merges the results by decision id viaherald/github/render.py;Posture
Tests
tests/test_herald_action.py— structural contract tests in the house style: composite wiring, exact input set, triple-dot diff, renderer hand-off, and the never-gate comment step.tests/test_herald_renderer.py— behavioral battery against the published engine: sorted/deduplicated rendering with scope and link assertions, the empty state, survivability of a bad changed path, the<details>overflow atmax-inline, and byte-determinism under reversed input order..github/workflows/tests.yml— the structural job now excludes the behavioral file; a newherald-rendererjob installs the publishedrac-coreand runs the battery, keeping the structural tier engine-free.Full suite: 23 passed.