Switched to go.uber.org/mock in v2#29
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 90.69% 89.89% -0.80%
==========================================
Files 4 4
Lines 430 495 +65
==========================================
+ Hits 390 445 +55
- Misses 32 42 +10
Partials 8 8 ☔ View full report in Codecov by Sentry. |
…nto renovate/all Merged from master
ttrann6
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to go.uber.org/mock in v2 due to resolve snyk issues found in component-httpstats introduced by github.com/asecurityteam/httpstats@v2.4.0
https://app.snyk.io/org/atlassian-security-open-source/project/3a0fa179-11a9-4f22-aa18-67fa4b08e188/pr-check/15bbbbc8-cf28-4b99-963a-ed6571975f3f
All 8 issues come from crypto which gets removed by this upgrade. Additionally golang/mock is archived and the suggested path is to switch to the fork.