Skip to content

Conversation

@brionmario
Copy link
Member

Purpose

This pull request addresses a bug with the password field type in the sign-up component and improves the user interface by making input labels more readable. The most significant changes include fixing the password field type handling and updating label formatting to better support camelCase field names.

Bug fix and input handling:

  • Ensured the correct field type (password) is used when generating input variants, labels, and placeholders in the convertSimpleInputToComponent function in transformer.ts, preventing potential UI or validation issues. [1] [2]

User interface improvements:

  • Updated the getInputLabel function in transformer.ts to convert camelCase field names to sentence case (e.g., firstName becomes First name), improving label readability for end users.

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@brionmario brionmario force-pushed the fix-asgardeo-v2-signup branch from 4e8521b to d2ac85b Compare November 14, 2025 07:48
@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit 65cdc32 into asgardeo:main Nov 14, 2025
3 of 6 checks passed
@brionmario brionmario changed the title fix: fix password field type in SignUp in AsgardeoV2 AKA Thunder ⚡ fix: fix password field type in SignUp in Thunder ⚡ Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants