Skip to content

fix: fix password field type in SignUp in Thunder ⚡ #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brionmario merged 2 commits into from
Nov 14, 2025
Merged

fix: fix password field type in SignUp in Thunder ⚡ #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb21aa
fix: fix password field type
brionmario Nov 14, 2025
d2ac85b
chore: add changeset 🦋
brionmario Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-words-grow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@asgardeo/react': patch
---

Fix password field type
14 changes: 10 additions & 4 deletions packages/react/src/components/presentation/SignUp/transformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,13 @@ const getInputLabel = (name: string, type: string, t: UseTranslation['t']): stri
const label: string = t(i18nKey);

if (label === i18nKey || !label) {
return name.charAt(0).toUpperCase() + name.slice(1);
// Convert camelCase to sentence case (e.g., "firstName" -> "First name")
// TODO: Need to remove this one the following improvement is done.
// Tracker: https://github.com/asgardeo/thunder/issues/725
return name
.replace(/([A-Z])/g, ' $1')
.replace(/^./, str => str.toUpperCase())
.trim();
}

return label;
Expand Down Expand Up @@ -102,9 +108,9 @@ const convertSimpleInputToComponent = (
fieldType = 'password';
}

const variant: 'TEXT' | 'EMAIL' | 'PASSWORD' = getInputVariant(input.type, input.name);
const label: string = getInputLabel(input.name, input.type, t);
const placeholder: string = getInputPlaceholder(input.name, input.type, t);
const variant: 'TEXT' | 'EMAIL' | 'PASSWORD' = getInputVariant(fieldType, input.name);
const label: string = getInputLabel(input.name, fieldType, t);
const placeholder: string = getInputPlaceholder(input.name, fieldType, t);

return {
id: generateId('input'),
Expand Down
Loading