Win32: Visual Studio 2017 support using CMake#443
Merged
Conversation
strcasestr is not available on MS C runtime. Use strncasecmp instead which is in POSIX. MS C runtime has _strnicmp().
This CMakeLists.txt only meant for Win32 MSVC builds. For POSIX platforms, it is recommended using Makefile.
Remove chibi-scheme.vcproj to prevent interfere with CMake builds.
Disable ashinn#435 for Win32 as it is only meant for UNIX platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual Studio 2017 compilation support using CMake which is bundled with VS2017.
Currently, it does not support amd64 (and ARMs).
strcasestrand usestrncasecmpinstead. Both are not standard C function but latter has_strnicmpon Win32 libc.scheme-r7rscommand name as in SRFI 22. #435 with_WIN32as the SRFI meant for UNIX platforms.vcprojCMakeLists.txtto test with. Currently it does NOT support;SEXP_USE_DLand platforms other than Windows. It is only meant to keep C portability for further updates. Feel free to call me whenever it broken by further commits..CI: https://ci.appveyor.com/project/okuoku/chibi-scheme/build/1.0.17
Currently it is broken on:
FAIL: (eqv?: 0.14285714285714282 0.14285714285714288).