harden: scope release token out of npm test - #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
releasejob'sactions/checkoutran withpersist-credentialsat its default (true), so the write-scopedGITHUB_TOKEN(contents: write+actions: write+id-token: write) was written into.git/configas anhttp.<url>.extraheaderauth token. The job then runsnpm ciand the build/test steps with that credential still on disk — so a malicious or compromised dependency executing during install/typecheck/build/test could read the token out of.git/configand use its write scope (push to the repo, dispatch workflows, mint attestations).Fix
persist-credentials: falseto the checkout step so the token is never persisted into.git/config.git push. It creates the tag and GitHub release through theghCLI (which authenticates viaGH_TOKENin the stepenv, not the on-disk git credential), and the read-onlygit ls-remote origintag-exists guard works unauthenticated on this public repo. Sopersist-credentials: falsealone is the complete fix.Everything else is byte-for-byte unchanged: the version-changed gate, tag-exists check, CHANGELOG extraction,
gh releasecreate/upload, keyless provenance attestation, and thepublish.ymldispatch.Mirrors the same fix already merged in the sibling truecopy repo.