Show a user-friendly error when no embedding model is configured - #553
Merged
haiphucnguyen merged 1 commit intoJul 24, 2026
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
haiphucnguyen
approved these changes
Jul 24, 2026
haiphucnguyen
left a comment
haiphucnguyen
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @AnayGarodia
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #549
When a user opens a project with reference materials but has not configured an embedding model, indexing failed with the raw langchain4j builder error
modelName cannot be null or blankin the "Failed to index knowledge source" dialog.This adds a guard before building the embedding model, so the resolved-but-blank model name now surfaces as an actionable message, matching the existing wording style used in
ensureLocalEmbeddingModelAvailable:Applied in the two paths where the resolved model name can be blank (provider setting and AppConfig default both empty):
OpenAiCompatibleChatModelFactory.createEmbeddingModel(Ollama, Docker AI, LocalAI, LM Studio, etc.)OpenAiCompatibleModelFactory.createEmbeddingModel(generic OpenAI-compatible provider)Ran
./gradlew spotlessApply detekt test— all pass.