perf: avoid array allocation in C# operator name lookup and substring in Go recover check

[github-actions]

🤖 This pull request was created by Repo Assist, an automated AI assistant.

Summary

Two targeted micro-optimizations that reduce allocation pressure in the C# and Go analyzers.

---

1. Go: length short-circuit in isRecoverCall

File: src/metricsAnalyzer/languages/goAnalyzer.ts

Every call_expression node in a Go file triggers isRecoverCall. Previously, this always called sourceText.substring(startIndex, endIndex) — a string allocation — to compare against "recover". Since recover is exactly 7 characters, we can short-circuit with an integer comparison first:

// Before: substring allocation on every call_expression
return this.sourceText.substring(funcNode.startIndex, funcNode.endIndex) === "recover";

// After: O(1) length check eliminates allocation for 99%+ of calls
if (funcNode.endIndex - funcNode.startIndex !== 7) { return false; }
return this.sourceText.substring(funcNode.startIndex, funcNode.endIndex) === "recover";

In a typical Go file with many function calls, this avoids a string allocation for all non-recover call sites.

---

2. C#: replace node.children.find() with direct node.child(i) access

File: src/metricsAnalyzer/languages/csharpAnalyzer.ts

node.children in tree-sitter is a getter that materialises a new JavaScript array on every call. Two places in getFunctionName used node.children.find(...), which allocates an array every time getFunctionName runs:

• conversion_operator_declaration: The implicit/explicit keyword appears in the first 4 children (after 0–3 modifier nodes). Replaced with a bounded for loop using node.child(i) — no array allocation.
• Identifier fallback: Replaced node.children.find(child => child.type === "identifier") with a for loop using node.child(i), also avoiding the array allocation.

---

Trade-offs

• Both changes are purely mechanical — no behavioral change, no new logic.
• The length check adds one integer subtraction per call_expression; this is negligible compared to the allocation saved.
• The C# loop bound of 4 for conversion_operator_declaration is safe: C# modifiers on conversion operators are at most public, static, new (3 modifiers), so implicit/explicit is always at index ≤ 3.

---

Test Status

npm run compile  ✅  (0 TypeScript errors)
npm run lint     ✅  (0 ESLint warnings)
unit tests       ✅  199 passing, 0 failing

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by 🌈 Repo Assist, see workflow run. Learn more.
_{Comment /repo-assist to run again}

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@42c2ab5b4e4c9273534c39259b2e0df7f20f07e9

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.37%. Comparing base (445d848) to head (057a0d3).

Files with missing lines	Patch %	Lines
src/metricsAnalyzer/languages/csharpAnalyzer.ts	70.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   81.39%   81.37%   -0.02%     
==========================================
  Files          13       13              
  Lines        4353     4366      +13     
  Branches      441      442       +1     
==========================================
+ Hits         3543     3553      +10     
- Misses        809      812       +3     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR applies two micro-optimizations in the Go and C# metrics analyzers to reduce allocation overhead while traversing Tree-sitter AST nodes during cognitive complexity analysis.

Changes:

• Go: add a length short-circuit in isRecoverCall to avoid most substring calls.
• C#: replace node.children.find(...) with node.child(i) loops to avoid node.children array materialization.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/metricsAnalyzer/languages/goAnalyzer.ts	Adds a constant-time length guard before extracting the callee identifier text.
src/metricsAnalyzer/languages/csharpAnalyzer.ts	Replaces node.children scans with child(i) loops to avoid array allocation in function-name extraction.