fix: make SSR hydration interactions reliable - #83
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts SSR hydration listener installation to improve cross-browser reliability (notably addressing Windows CI failures) by ensuring hydrated event handlers are attached as direct element listeners during the SSR-to-client handoff.
Changes:
- Add a
forceDirectpath toaddTrackedListenerand use it during hydration publication. - Prevent hydration-staged listeners from publishing as delegated listeners (even when delegation is enabled), to avoid delegated-container propagation inconsistencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smiggleworth
force-pushed
the
fix/askr-windows-ssr-hydration
branch
from
July 25, 2026 21:21
8d4896d to
c29134a
Compare
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82.
Hydrated event handlers now publish as direct element listeners during the SSR-to-client handoff. Client-created and subsequent re-rendered elements retain delegated listeners. This avoids browser-host differences in delegated-container propagation while preserving normal delegation after hydration.
Validation: full unit, checks, jsdom, browser, lint/typecheck, build, and installed type gates pass locally.