Skip to content

fix: update install script - #22

Merged
aspectrr merged 1 commit into
mainfrom
aspectrr/landing-page-install.sh
Feb 4, 2026
Merged

fix: update install script#22
aspectrr merged 1 commit into
mainfrom
aspectrr/landing-page-install.sh

Conversation

@aspectrr

@aspectrr aspectrr commented Feb 4, 2026

Copy link
Copy Markdown
Owner

Description

  • fix install.sh script

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code style update (formatting, renaming)
  • Code refactor (no functional changes)
  • Configuration change
  • Test update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Release Notes

Labels

Copilot AI review requested due to automatic review settings February 4, 2026 14:05
@aspectrr
aspectrr merged commit 6c31ead into main Feb 4, 2026
8 of 10 checks passed
@aspectrr
aspectrr deleted the aspectrr/landing-page-install.sh branch February 4, 2026 14:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the landing page’s install.sh endpoint to install the fluid CLI from the correct Go module path.

Changes:

  • Switches go install from github.com/aspectrr/fluid@latest to github.com/aspectrr/fluid.sh/fluid/cmd/fluid@latest
  • Updates the corresponding “Running:” log line in the script output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +49 to +50
echo "Running: go install github.com/aspectrr/fluid.sh/fluid/cmd/fluid@latest"
go install github.com/aspectrr/fluid.sh/fluid/cmd/fluid@latest

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated script declares #!/bin/sh, but earlier it uses the Bash-only redirection operator &> in command -v go &> /dev/null. On systems where /bin/sh is dash (common on Ubuntu/Debian), this can cause a syntax error and break installation. Prefer a POSIX-compatible redirect (>/dev/null 2>&1) or change the shebang/instructions to explicitly require Bash.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants