fix: update install script - #22
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the landing page’s install.sh endpoint to install the fluid CLI from the correct Go module path.
Changes:
- Switches
go installfromgithub.com/aspectrr/fluid@latesttogithub.com/aspectrr/fluid.sh/fluid/cmd/fluid@latest - Updates the corresponding “Running:” log line in the script output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+50
| echo "Running: go install github.com/aspectrr/fluid.sh/fluid/cmd/fluid@latest" | ||
| go install github.com/aspectrr/fluid.sh/fluid/cmd/fluid@latest |
There was a problem hiding this comment.
The generated script declares #!/bin/sh, but earlier it uses the Bash-only redirection operator &> in command -v go &> /dev/null. On systems where /bin/sh is dash (common on Ubuntu/Debian), this can cause a syntax error and break installation. Prefer a POSIX-compatible redirect (>/dev/null 2>&1) or change the shebang/instructions to explicitly require Bash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
Release Notes
Labels