fix: remove insecure StrictHostKeyChecking from SSH documentation example#3
Merged
Conversation
14 tasks
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ecure host key management guidance Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com>
Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com>
Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com>
Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update sdk prefix and sandbox-init connection based on feedback
fix: remove insecure StrictHostKeyChecking from SSH documentation example
Jan 2, 2026
14 tasks
aspectrr
added a commit
that referenced
this pull request
Jan 11, 2026
…mple (#3) * feat: fix sdk prefix, add sandbox-init connection * fix: fix sdk generation check * fix: fix workflows for sdk * Initial plan * fix: remove insecure StrictHostKeyChecking from SSH example and add secure host key management guidance Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com> * fix: add fingerprint verification step to SSH example Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com> * docs: clarify secure out-of-band verification for host keys Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com> * docs: add note about VM console access for secure key export Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com> --------- Co-authored-by: aspectrr <collin@steelbrowser.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aspectrr <45578837+aspectrr@users.noreply.github.com> Co-authored-by: Collin Pfeifer <collinpfeifer@Icloud.com>
14 tasks
aspectrr
added a commit
that referenced
this pull request
Mar 15, 2026
* feat: add fluid connect command and TUI connect wizard - Add `fluid connect <address>` CLI command: tests gRPC connection, runs doctor checks, and saves daemon to config - Add TUI /connect wizard with multi-step flow (address input, connecting, doctor checks, done) - Add Cancel() to AgentRunner interface and ESC key support to abort running agent - Add SetSandboxService() to hot-swap daemon connection after /connect - Extend readonly prepare/validate/shell in both cli and daemon - Update web docs: daemon-setup-steps, quickstart-steps, cli-reference Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use fmt.Fprintf instead of WriteString(fmt.Sprintf(...)) in connect.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: replace remaining WriteString(fmt.Sprintf(...)) with fmt.Fprintf in connect.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use go env GOPATH to locate gofumpt in lefthook pre-commit hook Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: add connect command * fix: replace WriteString(fmt.Sprintf(...)) with fmt.Fprintf in connect.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: fix writef * fix: fix PR review issues * fix: fix PR review issues 2 * fix: finale PR fixes * fix: remove unused * fix: PR review * fix: PR review #3 * fix: PR review #4 * fix: PR review #5 * feat: pii redaction docs, fixing nitys * fix: make pii redaction correct with what LLM sees, remove tls cert * fix: PR nits * fix: redaction issues and openssl * fix: move readonly to shared --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed
-o StrictHostKeyChecking=nofrom the SSH connection example in the scripts README, which disabled host key verification and allowed trivial man-in-the-middle attacks.Changes:
StrictHostKeyChecking=nooption from SSH example commandssh-keyscanandssh-keygen -lfBefore:
ssh -i /tmp/sandbox_key \ -o CertificateFile=/tmp/sandbox_key-cert.pub \ -o StrictHostKeyChecking=no \ sandbox@192.168.122.xAfter:
Type of Change
Checklist
Release Notes
Fixed security vulnerability in SSH documentation example by removing
StrictHostKeyChecking=noand adding proper host key verification guidance.Labels
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.