Aspectrr/sandbox id sdk#5
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds sandbox ID functionality to the session client and performs a major SDK update. The changes include adding a new sandboxes listing endpoint, implementing architecture detection for VM cloning to support multiple CPU architectures (x86_64 and aarch64), and converting the Python SDK from async to synchronous operations.
Key Changes:
- Added
/v1/sandboxesendpoint for listing sandboxes with filtering capabilities - Implemented architecture detection from source VMs to properly clone across different CPU architectures
- Converted Python SDK from async/await pattern to synchronous operations
- Added development documentation (AGENTS.md) for web, virsh-sandbox, and tmux-client components
- Updated SDK version from 0.0.6-beta to 0.0.12-beta
Reviewed changes
Copilot reviewed 99 out of 101 changed files in this pull request and generated 40 comments.
Show a summary per file
| File | Description |
|---|---|
| web/CLAUDE.md, web/AGENTS.md | Added documentation redirect and comprehensive development guidelines |
| virsh-sandbox/ssh_config | Added SSH configuration for Lima VM access |
| virsh-sandbox/internal/rest/server.go | Added list sandboxes endpoint with filtering support |
| virsh-sandbox/internal/libvirt/virsh.go | Added architecture detection and multi-arch XML template support |
| virsh-sandbox/docs/openapi.yaml | Updated OpenAPI spec with new endpoints and cleaned up schema references |
| virsh-sandbox/Dockerfile | Added SSH config setup for Lima VM connectivity |
| virsh-sandbox/CLAUDE.md, AGENTS.md | Added development documentation |
| tmux-client/docs/openapi.yaml, CLAUDE.md, AGENTS.md | Updated API specs and added documentation |
| sdk/virsh-sandbox-py/virsh_sandbox/* | Converted SDK from async to sync, added new model classes |
| sdk/virsh-sandbox-py/setup.py | Bumped version to 0.0.12-beta |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aspectrr
added a commit
that referenced
this pull request
Jan 11, 2026
* chore: add in sandbox-id to sdk client * fix: sandbox creation works * chore: add to AGENTS.md, add sdk tests * fix: update sdk to 0.0.10b0 * fix: update sdk to 0.0.12b0 * fix: update sdk to remove re, update sandboxes to autostart
14 tasks
aspectrr
added a commit
that referenced
this pull request
Mar 15, 2026
* feat: add fluid connect command and TUI connect wizard - Add `fluid connect <address>` CLI command: tests gRPC connection, runs doctor checks, and saves daemon to config - Add TUI /connect wizard with multi-step flow (address input, connecting, doctor checks, done) - Add Cancel() to AgentRunner interface and ESC key support to abort running agent - Add SetSandboxService() to hot-swap daemon connection after /connect - Extend readonly prepare/validate/shell in both cli and daemon - Update web docs: daemon-setup-steps, quickstart-steps, cli-reference Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use fmt.Fprintf instead of WriteString(fmt.Sprintf(...)) in connect.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: replace remaining WriteString(fmt.Sprintf(...)) with fmt.Fprintf in connect.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: use go env GOPATH to locate gofumpt in lefthook pre-commit hook Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: add connect command * fix: replace WriteString(fmt.Sprintf(...)) with fmt.Fprintf in connect.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: fix writef * fix: fix PR review issues * fix: fix PR review issues 2 * fix: finale PR fixes * fix: remove unused * fix: PR review * fix: PR review #3 * fix: PR review #4 * fix: PR review #5 * feat: pii redaction docs, fixing nitys * fix: make pii redaction correct with what LLM sees, remove tls cert * fix: PR nits * fix: redaction issues and openssl * fix: move readonly to shared --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the sandbox-id to the session client. Updated sdk, updated run command
Type of Change
Checklist
Release Notes
Labels