This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Cleanup EventSource logging provider #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
🐑 🇮🇹 |
pranavkm
approved these changes
Oct 31, 2016
| /// </remarks> | ||
| internal class EventSourceLogger : ILogger | ||
| { | ||
| private static int _activityIds; |
Contributor
There was a problem hiding this comment.
_activityId? Also, should this be a non-static. cc @davidfowl for an opinion.
Contributor
Author
There was a problem hiding this comment.
It's used to get unique id's for scopes.
Contributor
There was a problem hiding this comment.
Ahh, this is not the logger provider. Ok. Seems crummy though to rely on statics to do this.
This was referenced Nov 1, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pranavkm