Use CurrentConfiguration before ConfigurationManager#216
Merged
StephenMolloy merged 1 commit intomainfrom Jan 17, 2023
Merged
Conversation
…ameter values from AppSettings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use CurrentConfiguration before ConfigurationManager when reading parameter values from AppSettings. Like #210, except in the 'reading parameters from AppSettings' code.
I believe these are the only two places we used ConfigurationManager to access config. (Which works perfectly fine when reading our own processes config - which is the case 9/10 times.)