Skip to content

Use CurrentConfiguration before ConfigurationManager #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephenMolloy merged 1 commit into from
Jan 17, 2023
Merged

Use CurrentConfiguration before ConfigurationManager #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Base/KeyValueConfigBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,17 @@ protected string UpdateConfigSettingWithAppSettings(string configName)
});
}

// Try to use CurrentConfiguration before falling back to ConfigurationManager. Otherwise OpenConfiguration()
// scenarios won't work because we're looking in the wrong processes AppSettings.
else if (CurrentSection?.CurrentConfiguration?.AppSettings is AppSettingsSection currentAppSettings)
{
configValue = Regex.Replace(configValue, _tokenPattern, (m) =>
{
string settingName = m.Groups[1].Value;
return (currentAppSettings.Settings[settingName]?.Value ?? m.Groups[0].Value);
});
}

// All other config sections can just go through ConfigurationManager to get app settings though. :)
else
{
Expand Down