Reenable Music store tests

[HaoK]

Fallback hosting changes appear to have broken the Smoke tests, they appear to work in that they are calling functionality, but the tests all fail at the end, I've disabled the tests for now.

[Praburaj]

Whats the point in disabling tests if product bits are regressed? These E2Etests are mainly to stop broken bits entering the myget feed.

[davidfowl]

Are these tests busted because they were using fallback or because of something else?

[HaoK]

They are doing their own form of hosting/deployment to run in a bunch of different scenarios. It looked like they were all failing after the scenario tests ran. I asked suhas if he thought I should disable the tests or leave them broken. He suggested disabling is slightly better since that would make it easier to debug the failures with the packages available.

On Nov 21, 2014, at 8:45 AM, "David Fowler" <notifications@github.commailto:notifications@github.com> wrote:

Are these tests busted because they were using fallback or because of something else?

Reply to this email directly or view it on GitHubhttps://github.com//issues/292#issuecomment-63999170.

[Praburaj]

Let me try to understand this a bit more. All the tests do is start iis express pointing to the path or run k web which is the normal. The tests are failing as the service IHostingEnvironment is missing in the container.

<span class="light exception">System.Exception</span><br />
[18:28:19][xunit-test]     <span class="heavy">TODO: No service for type &#39;Microsoft.AspNet.Hosting.IHostingEnvironment&#39; has been registered.</span><br />
[18:28:19][xunit-test]     
[18:28:19][xunit-test]     <div class="stacktrace">
[18:28:19][xunit-test]         <pre><span class="faded">at Microsoft.Framework.DependencyInjection.</span>ServiceProviderExtensions.GetRequiredService<span class="faded">(IServiceProvider provider, Type serviceType)</span></pre>
[18:28:19][xunit-test] <br /><pre><span class="faded">at Microsoft.Framework.DependencyInjection.</span>ServiceProviderExtensions.GetRequiredService&lt;T&gt;<span class="faded">(IServiceProvider provider)</span></pre>
[18:28:19][xunit-test] <br /><pre><span class="faded">at Microsoft.AspNet.Loader.IIS.</span>KlrHttpApplication.ApplicationStart<span class="faded">(IHttpApplication application)</span></pre>
[18:28:19][xunit-test] <br /><pre><span class="faded">at Microsoft.AspNet.Loader.IIS.</span>HttpApplicationBase.InvokeApplicationStart<span class="faded">(IHttpApplication application)</span></pre>

[HaoK]

Yeah I attempted to fix program.cs music store which is adding its own hostingenvironment which none of the other tests were doing. I will stop by when i get in.

On Nov 21, 2014, at 9:46 AM, "Praburaj Thiagarajan" <notifications@github.commailto:notifications@github.com> wrote:

Let me try to understand this a bit more. All the tests do is start iis express pointing to the path or run k web which is the normal. The tests are failing as the service IHostingEnvironment is missing in the container.

System.Exception

[18:28:19][xunit-test] TODO: No service for type 'Microsoft.AspNet.Hosting.IHostingEnvironment' has been registered.

[18:28:19][xunit-test]
[18:28:19][xunit-test]

[18:28:19][xunit-test]

at Microsoft.Framework.DependencyInjection.ServiceProviderExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)

[18:28:19][xunit-test]

at Microsoft.Framework.DependencyInjection.ServiceProviderExtensions.GetRequiredService<T>(IServiceProvider provider)

[18:28:19][xunit-test]

at Microsoft.AspNet.Loader.IIS.KlrHttpApplication.ApplicationStart(IHttpApplication application)

[18:28:19][xunit-test]

at Microsoft.AspNet.Loader.IIS.HttpApplicationBase.InvokeApplicationStart(IHttpApplication application)

Reply to this email directly or view it on GitHubhttps://github.com//issues/292#issuecomment-64009208.

[davidfowl]

Ah, that makes sense. Program.cs in here is busted anyways 😄

[Praburaj]

I discussed with Hao offline. Program.cs is never used by tests. It lives just for a demo sake to show how to start a web app in a vnext console app. A basic hello world web app is broken. Hao has a repro and working on a fix.

[davidfowl]

That's pretty bad 😄

[HaoK]

Yeah, one of the last minute changes broke things, I think its just one line in KlrHttpApplication in Helios which is calling GetRequiredService on the wrong serviceProvider now that its coming from hosting...

[HaoK]

Tests reenabled, Helios tests are passing locally, will follow up on WebListener/Kestrel