PROD | filter out deleted clients from company member list

[arpandhakal]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tasks-app	Ready	Preview, Comment	Jun 30, 2026 7:00am

[vercel]

Deployment failed with the following error:

Deploying Serverless Functions to multiple regions is restricted to the Pro and Enterprise plans.

Learn More: https://vercel.link/multiple-function-regions

[greptile-apps]

Greptile Summary

This PR filters out deleted clients from the result of _getCompanyClients, preventing them from appearing in the company member list. The change is a single-line client-side filter applied after the Copilot API response is fetched.

• _getCompanyClients now excludes any ClientResponse where status === 'deleted' before returning the list to callers such as the notification service, task-sharing service, and reminder job.
• The status field is guaranteed to be a non-null string by the Zod schema (ClientResponseSchema), so the comparison is safe.

Confidence Score: 4/5

The change is a minimal, targeted client-side filter with no side effects on other callers; the status field is always present per the Zod schema, so the comparison cannot panic at runtime.

The fix is correct and well-scoped — deleted clients will no longer surface in the company member list, notification recipients, or task-sharing queries. The only open question is whether the hardcoded lowercase string 'deleted' matches every possible value the upstream Copilot API can return, since the schema accepts any string.

src/utils/CopilotAPI.ts — specifically the status field definition in ClientResponseSchema in src/types/common.ts, which remains an unconstrained string type.

Important Files Changed

Filename	Overview
src/utils/CopilotAPI.ts	Adds a client-side filter in _getCompanyClients to exclude clients whose status equals the hard-coded string 'deleted'; the fix is correct and the field is always present per the Zod schema, but the status value is an untyped plain string rather than an enum.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Caller
    participant CopilotAPI
    participant CopilotSDK

    Caller->>CopilotAPI: getCompanyClients(companyId)
    CopilotAPI->>CopilotSDK: "listClients({ limit: 10000, companyId })"
    CopilotSDK-->>CopilotAPI: ClientsResponse (includes deleted clients)
    Note over CopilotAPI: filter(c => c.status !== 'deleted')
    CopilotAPI-->>Caller: ClientResponse[] (deleted clients excluded)

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Caller
    participant CopilotAPI
    participant CopilotSDK

    Caller->>CopilotAPI: getCompanyClients(companyId)
    CopilotAPI->>CopilotSDK: "listClients({ limit: 10000, companyId })"
    CopilotSDK-->>CopilotAPI: ClientsResponse (includes deleted clients)
    Note over CopilotAPI: filter(c => c.status !== 'deleted')
    CopilotAPI-->>Caller: ClientResponse[] (deleted clients excluded)

Loading

_{Reviews (1): Last reviewed commit: "Merge branch 'production' into main" | Re-trigger Greptile}

[greptile-apps]

The status field in ClientResponseSchema is typed as z.string() — a plain, unconstrained string. If the Copilot API ever returns a differently-cased value (e.g. 'Deleted') or a related variant (e.g. 'deactivated'), the filter will silently miss those clients. Consider narrowing the schema to a z.enum to make valid statuses explicit and catch unexpected values at parse time.

Suggested change

	return clients.filter((c) => c.status !== 'deleted')
	return clients.filter((c) => c.status?.toLowerCase() !== 'deleted')

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[priosshrsth]

lgtm