Remove the country code in the translation files and add Spanish translation - #35
Closed
SosthenG wants to merge 2 commits into
Closed
Remove the country code in the translation files and add Spanish translation#35SosthenG wants to merge 2 commits into
SosthenG wants to merge 2 commits into
Conversation
|
❌ The last analysis has failed. |
1 similar comment
|
❌ The last analysis has failed. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Translation resource files were named after a specific country variant (en_US, fr_FR) instead of the base language. Symfony's translator resolves a requested locale by progressively falling back to its parent (e.g. en_GB → en, fr_CA → fr), so naming the files after the base language lets them serve any regional variant of that language, not just the one hardcoded in the filename. It also matches the convention for the new Spanish file, which isn't tied to a specific country either.