Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Apr 14, 2025

This PR contains the following updates:

Package Type Update Change
actions/checkout action digest 11bd719 -> 85e6279

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the internal An internal refactor or improvement label Apr 14, 2025
@AlexWaygood
Copy link
Member

@Gankra I guess we should disable renovate update PRs for release.yml, since it's generated by cargo-dist?

@Gankra
Copy link
Contributor

Gankra commented Apr 15, 2025

possibly -- at the very least they need to be treated as prompts to edit the config and regen, instead of things you merge unchanged.

@AlexWaygood
Copy link
Member

Hmmm... I'm not sure I trust our ability to remember to do that whenever a renovate PR touches release.yml (I'll definitely forget 😆), so it sounds like disabling the renovate PRs for this file only might be the best option.

Thanks!

@dhruvmanila
Copy link
Member

Hmmm... I'm not sure I trust our ability to remember to do that whenever a renovate PR touches release.yml (I'll definitely forget 😆), so it sounds like disabling the renovate PRs for this file only might be the best option.

If it's possible, we could add a CI check to run dist generate which should fail if there are any changes.

@Gankra
Copy link
Contributor

Gankra commented Apr 16, 2025

cargo dist plan is designed to error if generate isn't a noop

@Gankra
Copy link
Contributor

Gankra commented Apr 16, 2025

And the cargo-dist CI automatically runs in a minimal mode that just does plan if this value is set to "plan" -- I'm not sure why it was flipped off.

ruff/Cargo.toml

Lines 308 to 309 in 13ea4e5

# Which actions to run on pull requests
pr-run-mode = "skip"

@dhruvmanila
Copy link
Member

After #17453 is merged, we can ask renovate to rebase and verify whether the CI fails or not and start merging these PRs.

@renovate renovate bot changed the title Update actions/checkout digest to 85e6279 Update actions/checkout digest to 85e6279 - autoclosed Apr 22, 2025
@renovate renovate bot closed this Apr 22, 2025
@renovate renovate bot deleted the renovate/actions-checkout-digest branch April 22, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants