Present Windows transcript replay in one terminal update - #13
Closed
astral303 wants to merge 1 commit into
Closed
Conversation
Windows Terminal can expose a cleared or partially replayed frame when resize repair spans its 100 ms synchronized-output window. - Keep the clear target and source rows pending until clear, replay, draw, and reconciliation all succeed, so I/O failures retry the complete transaction. - Pre-wrap replay rows before synchronized output and buffer each history insertion before its backend write, keeping expensive preparation outside the presentation window. - Defer history-tail replacement while replay is pending so asynchronous status updates cannot split the transaction. - Cover ordering and retries after clear, history-write, and frame-draw failures. Refs: openai#38839
This was referenced Aug 17, 2026
Owner
Author
|
Closing this implementation because it depends on the retired openai#30745 InlineViewportState architecture superseded by openai#39619. This does not resolve openai#38839; that issue still needs reassessment against the current ScrollbackStrategy architecture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #6.
What Changed
InlineViewportStatetransaction.Design
Tuistill orchestrates drawing.InlineViewportStateowns the Windows-specific replay mechanics and retry state, extending the platform facade introduced by the openai#30745 stack without adding platform branches totui.rs.The clear -> replay -> redraw ordering comes from wellorbetter's candidate. This version also keeps the complete operation retryable and prepares reflowed output before entering the synchronized update.
Validation
codex-tuisuite passed 3,633 tests; its three existing Windows~path-shortening failures remain unchanged.Addresses openai#38839.
Stack
#6 source-backed reflow-> this production fix ->#7 interactive Windows tests