Skip to content

Fix conesearch tutorial #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrn merged 3 commits into from
May 8, 2018
Merged

Fix conesearch tutorial #230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b401a2
use cat not more
adrn Apr 9, 2018
9d85fca
fix vizier url
adrn May 8, 2018
837617c
back to hard-coding URL
adrn May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions tutorials/notebooks/vo/conesearch.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"collapsed": true
},
"metadata": {},
"outputs": [],
"source": [
"# Python standard library\n",
Expand Down Expand Up @@ -125,9 +123,7 @@
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"collapsed": true
},
"metadata": {},
"outputs": [],
"source": [
"result_tab.write('my_result.tex', format='ascii.latex')"
Expand All @@ -141,7 +137,7 @@
"source": [
"# Now use your favorite text editor to open the my_result.tex file.\n",
"# For example:\n",
"!more my_result.tex"
"!cat my_result.tex"
Copy link
Contributor

@pllim pllim May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, does your machine not have more?

Copy link
Contributor Author

@adrn adrn May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my machine, more never lets the cell finish executing, so subsequent cells never run.

Copy link
Contributor

@pllim pllim May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 ok

]
},
{
Expand All @@ -155,9 +151,7 @@
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"collapsed": true
},
"metadata": {},
"outputs": [],
"source": [
"# Due to the unpredictability of external services,\n",
Expand Down Expand Up @@ -320,9 +314,7 @@
{
"cell_type": "code",
"execution_count": null,
"metadata": {
"collapsed": true
},
"metadata": {},
"outputs": [],
"source": [
"with warnings.catch_warnings():\n",
Expand All @@ -346,7 +338,7 @@
"metadata": {},
"outputs": [],
"source": [
"my_favorite_result = all_results['http://vizier.u-strasbg.fr/viz-bin/votable/-A?-out.all&-source=I/220/out&']\n",
"my_favorite_result = all_results['http://vizier.u-strasbg.fr/viz-bin/conesearch/I/220/out?']\n",
"print(my_favorite_result.array.data.dtype.names)\n",
"print(my_favorite_result.array.data)"
]
Expand Down Expand Up @@ -482,7 +474,7 @@
"published": false
},
"kernelspec": {
"display_name": "Python 3",
"display_name": "Python [default]",
"language": "python",
"name": "python3"
},
Expand All @@ -496,7 +488,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.6.3"
"version": "3.6.4"
}
},
"nbformat": 4,
Expand Down