Override basic arithmetic operators #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Quantity or CCDData Closes astropy#38
The issue is reported at astropy/astropy#2377
mwcraig
added a commit
that referenced
this pull request
Apr 29, 2014
Override basic arithmetic operators
mwcraig
pushed a commit
to mwcraig/ccdproc
that referenced
this pull request
Jun 4, 2014
Use wheels on travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request overrides the methods
NDData.add,NDData.subtract,NDData.multiplyandNDData.divideto allowscalar * ccd_data_objectwherescalarcan be either a plain number or aastropy.units.Quantity. The case ofccd_data_object1 * ccd_data_object2is passed toNDData.Error is properly propagated in the scalar cases (propagation is handled by
NDDatain the other case).If the operand is a scalar then the result's metadata is that of the ccd_data object. If both operands are
CCDDataobjects then the result's metadata isNonebecause there is no way for the basic operations to know what the appropriate metadata should be.