Skip to content

Allow "lower" method to be missing when filtering#567

Merged
mwcraig merged 1 commit into
astropy:masterfrom
MSeifert04:allow_failure_on_lower
Oct 24, 2017
Merged

Allow "lower" method to be missing when filtering#567
mwcraig merged 1 commit into
astropy:masterfrom
MSeifert04:allow_failure_on_lower

Conversation

@MSeifert04
Copy link
Copy Markdown
Contributor

@MSeifert04 MSeifert04 commented Oct 19, 2017

Checklist:

  • Did you add an entry to the "Changes.rst" file?
  • Did you add a regression test?
  • Does the commit message include a "Fixes #issue_number" (replace "issue_number").
  • Does this PR add, rename, move or remove any existing functions or parameters?

Fixes #558

@MSeifert04 MSeifert04 added this to the 1.3 milestone Oct 19, 2017
@MSeifert04
Copy link
Copy Markdown
Contributor Author

MSeifert04 commented Oct 19, 2017

The failed CI build will be fixed if #566 is merged.

@MSeifert04 MSeifert04 changed the title Allow "lower" to be missing when filtering Allow "lower" method to be missing when filtering Oct 19, 2017
@mwcraig
Copy link
Copy Markdown
Member

mwcraig commented Oct 24, 2017

Looks good and now passing, so merging.

@mwcraig mwcraig merged commit 28ea1e2 into astropy:master Oct 24, 2017
@MSeifert04 MSeifert04 deleted the allow_failure_on_lower branch October 24, 2017 21:10
@MSeifert04 MSeifert04 mentioned this pull request Nov 1, 2017
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug ImageFileCollection

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

2 participants

@MSeifert04 @mwcraig