Catch warnings if no files are in the collection#583
Merged
mwcraig merged 1 commit intoastropy:masterfrom Oct 30, 2017
MSeifert04:catch_warnings_no_files_in_collection
Merged
Catch warnings if no files are in the collection#583mwcraig merged 1 commit intoastropy:masterfrom MSeifert04:catch_warnings_no_files_in_collection
mwcraig merged 1 commit intoastropy:masterfrom
MSeifert04:catch_warnings_no_files_in_collection
Conversation
Contributor
Author
|
@mwcraig @crawfordsm This should be straight-forward given that I just catch the warnings in the tests (and the CI passed). So if one of you wants to have a quick look over it (+merge if it looks alright) that would be great. :) |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems a bit odd that these are also emitted if one loads from an info-file but technically it's correct to emit them (and informational for the user) because the info-file doesn't populate the files attribute.