Fixes #90. Add auto_logging configuration parameter.

[lucarizzi]

If auto_logging is set to False and no add_keyword is specified,
ccdproc will not automatically create and add a keyword to the
metadata

Please have a look at the following list and replace the "[ ]" with a "[x]" if
the answer to this question is yes.

• For new contributors: Did you add yourself to the "Authors.rst" file?

For documentation changes:

• For documentation changes: Does your commit message include a "[skip ci]"?
  Note that it should not if you changed any examples!

For bugfixes:

• Did you add an entry to the "Changes.rst" file?
• Did you add a regression test?
• Does the commit message include a "Fixes #issue_number" (replace "issue_number").
• Does this PR add, rename, move or remove any existing functions or parameters?

For new functionality:

• Did you add an entry to the "Changes.rst" file?
• Did you include a meaningful docstring with Parameters, Returns and Examples?
• Does the commit message include a "Fixes #issue_number" (replace "issue_number").
• Did you include tests for the new functionality?
• Does this PR add, rename, move or remove any existing functions or parameters?

Please note that the last point is not a requirement. It is meant as a check if
the pull request potentially breaks backwards-compatibility.

[mwcraig]

Thanks for doing this, @lucarizzi! There are a couple of really minor changes to make then I think it is good to go.

If you would prefer I make the changes, just let me know.

[mwcraig]

Would you mind changing this to: if ccdproc.conf.auto_logging: (no need for the is True)?

[mwcraig]

Could you please also add the PR number (so that it is [#622, #90])?

[lucarizzi]

All done! I hope…. If anything remains to be done, feel free to make the changes. Luca

…

On May 14, 2018, at 2:52 PM, Matt Craig ***@***.***> wrote: @mwcraig commented on this pull request. Thanks for doing this, @lucarizzi <https://github.com/lucarizzi>! There are a couple of really minor changes to make then I think it is good to go. If you would prefer I make the changes, just let me know. In ccdproc/log_meta.py <#622 (comment)>: > @@ -98,15 +98,18 @@ def wrapper(*args, **kwd): meta_dict = _metadata_to_dict(log_result) else: # Logging is not turned off, but user did not provide a value - # so construct one. - key = func.__name__ - all_args = chain(zip(original_positional_args, args), kwd.items()) - all_args = ["{0}={1}".format(name, - _replace_array_with_placeholder(val)) - for name, val in all_args] - log_val = ", ".join(all_args) - log_val = log_val.replace("\n", "") - meta_dict = {key: log_val} + # so construct one unless the config parameter auto_logging is set to False + if ccdproc.conf.auto_logging is True: Would you mind changing this to: if ccdproc.conf.auto_logging: (no need for the is True)? In CHANGES.rst <#622 (comment)>: > @@ -15,6 +15,8 @@ Other Changes and Additions - Improved the performance of several ``ImageFileCollection`` methods. [#599] +- Added auto_logging configuration paramenter [#90] Could you please also add the PR number (so that it is [#622, #90])? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#622 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAgCnTCMbo9WPu96QNtaKMLPKduzkO2Mks5tyfyUgaJpZM4Txt11>.

[mwcraig]

Thanks @lucarizzi, merging!