Include Python 3.7 in test matrix #650
Conversation
MSeifert04
changed the title
mwcraig
left a comment
mwcraig
left a comment
There was a problem hiding this comment.
This is good to merge once tests pass, thanks again for updating the test matrix.
|
That didn't work: Travis: |
|
Oof. I'll try to look at astroscrappy this week. |
.travis.yml
Outdated
| - 3.4 | ||
| - 3.5 | ||
| - 3.6 | ||
| - 3.7 |
There was a problem hiding this comment.
I'm not sure travis supports this yet, try to use PYTHON_VERSION=3.7 instead lower down in the environment to tell conda to use that version. Even if it would we would install out conda version, too...
|
I think the failure we are seeing on appveyor is related to the old helpers version...or at least I see the same error on OSX locally if I try to build astroscrappy 1.05 but the build works for astroscrappy master. |
|
Hm, I tried various combinations but unless we have a 3.7 astroscrappy conda(-forge) build we might be stuck for now (except we make astroscrappy an optional dependency...) |
|
Yeah, at least the compilation of astroscrappy worked in appveyor. :) |
|
astroscrappy issue is astropy/astroscrappy#39 |
|
All the lights are green, so merging! |
|
👍 totally forgot about this. Thanks Matt |
3 participants
Closes #660