WIP lots of fixes for ImageFileCollection #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes astropy#679 by removing the ability to initialize from a table.
Fixes astropy#374 and Fixes astropy#661 Main change is how we handle a location of None.
Fixes astropy#662 (though to be honest I was not able to reproduce it)
instead of just extensions. Fixes astropy#620
Fixes astropy#607 even though this code was not what did the fix. This does add a check for the issue.
Fixes astropy#601 even though this code only adds a test
crawfordsm
reviewed
Jul 26, 2019
| ext: str or int, optional | ||
| The extension from which the header and data will be read in all files. | ||
| Default is ``0``. | ||
| ext: str or int, optional |
Member
There was a problem hiding this comment.
nitpick: since there is a default value, is it really optional?
Member
Author
There was a problem hiding this comment.
I think it is optional in the sense that you do not need to include it in the initializer because the default value will work well for most cases.
crawfordsm
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR still has a few commits incoming to close a couple more issues, but we'll see if the tests run.