-
-
Notifications
You must be signed in to change notification settings - Fork 133
Implement slicing and begin adding docs #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nmearl - why the update to the helpers? The current master has the latest release, unless specutils already requires python 3.5+ |
|
@bsipocz Huh, I'm not sure. It wasn't intentional. I'll remove it. |
| @@ -1,3 +0,0 @@ | |||
| [submodule "astropy_helpers"] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure you need to keep this content around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, seems to be what all the failing tests are complaining about. 😉 But trust me, I'm not trying to remove this stuff -- just seems like every once in awhile, the astropy_helpers submodule wants to fall apart for no particular reason. 😞
docs/contributing.rst
Outdated
| 2. If the pull request adds functionality, the docs should be updated. Put | ||
| your new functionality into a function with a docstring, and add the | ||
| feature to the list in README.rst. | ||
| 3. The pull request should work for Python 2.6, 2.7, 3.3, 3.4 and 3.5, and for PyPy. Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no testing for python 2.6&2.7&3.3, this requirement also needs updating. Just to be on the safe side you can hard wire the minimum requirement in setup.py, so the package won't even try to install for older versions
Make proper glue dataset to hold moment maps
No description provided.