Add support for SSO authentication #1831
Conversation
jderusse
force-pushed
the
sso-credential
branch
from
41fc3de to
fe93707
Compare
jderusse
force-pushed
the
sso-credential
branch
from
fe93707 to
a45ddbc
Compare
|
@jderusse I can try this out sometime in the new few hours. Thank you! |
|
@jderusse took me a couple of hours, and a sleep, to realize that I had a configuration bug when testing this. Now that I have resolved that, I am happy to report that this PR works perfectly. 🎉 |
| } | ||
|
|
||
| if (isset($profileData[IniFileLoader::KEY_SSO_START_URL])) { | ||
| if (class_exists(SsoClient::class)) { |
There was a problem hiding this comment.
this change the branches without inverting the condition
| } | ||
|
|
||
| if (isset($profileData[IniFileLoader::KEY_SSO_SESSION])) { | ||
| if (!class_exists(SsoClient::class)) { |
There was a problem hiding this comment.
shouldn't this check for SsoOidcClient instead ?
There was a problem hiding this comment.
already addressed by #1833
| 512, | ||
| \JSON_BIGINT_AS_STRING | (\PHP_VERSION_ID >= 70300 ? \JSON_THROW_ON_ERROR : 0) | ||
| ); | ||
| } catch (\JsonException $e) { |
There was a problem hiding this comment.
you also need the error handling for PHP 7.2 as it won't throw an error there.
|
Just came here to say I was trying to get this to work yesterday on a work project (using the Symfony bundle), landed here, followed this trail and discovered the release for 1.25 (also yesterday!), pulled it in and it worked! Thank you! This solved the only downside to us adopting async-aws. 🎉 🚀 |
4 participants
Fix #1581