Skip to content

feat: new channels#827

Closed
dignifiedquire wants to merge 2 commits into
masterfrom
feat-new-channels
Closed

feat: new channels#827
dignifiedquire wants to merge 2 commits into
masterfrom
feat-new-channels

Conversation

@dignifiedquire

@dignifiedquire dignifiedquire commented Jun 27, 2020

Copy link
Copy Markdown
Member
  • add new top level channel module
  • reimplement existing channels using async-channel

- add new top level `channels` module
- reimplement existing channels using `async-channel`
@ghost

ghost commented Jun 27, 2020

Copy link
Copy Markdown

Looks like channel module is in the wrong place: it's in async_std::channel, while it should be async_std::sync::channel

@yoshuawuyts

Copy link
Copy Markdown
Contributor

Looks like channel module is in the wrong place: it's in async_std::channel

@stjepang that's the intent; the libs team has been talking about possibly breaking std::sync up into smaller bits anyway, and we figured a channel impl would be a good candidate for this. But now that you know it's intentional I'm curious to hear what you think!

@ghost

ghost commented Jun 29, 2020

Copy link
Copy Markdown

Ha, interesting! I actually like channel as a top-level module and wish std did the same.

@dignifiedquire

Copy link
Copy Markdown
Member Author

Going to close this for now. Will rework later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants