docs: add high throughput properties for fifo#216
Merged
dpwdec merged 4 commits intoasyncapi:masterfrom Nov 1, 2023
Merged
Conversation
Gadam8
requested review from
KhudaDad414,
dpwdec and
iancooper
as code owners
Gadam8
changed the title
dpwdec
reviewed
Oct 26, 2023
dpwdec
reviewed
Oct 26, 2023
Collaborator
|
Is it appropriate to update the example in the |
added 2 commits
October 26, 2023 14:52
dpwdec
previously approved these changes
Oct 26, 2023
Collaborator
|
LGTM! |
Collaborator
|
@Gadam8 Please also add a minor version update 0.1.0 -> 0.2.0 |
dpwdec
approved these changes
Oct 26, 2023
Collaborator
|
@KhudaDad414 Can you take a look when you have a chance? Thanks 🙏 |
iancooper
approved these changes
Oct 26, 2023
Contributor
Author
|
@derberg @KhudaDad414 Could I get a review on this when you have a chance please? |
KhudaDad414
approved these changes
Nov 1, 2023
Member
KhudaDad414
left a comment
KhudaDad414
left a comment
There was a problem hiding this comment.
JSON Schema matches with the README file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing properties required to enable high throughput on a FIFO queue. The two properties are
deduplicationScopeandfifoThroughputLimit. As outlined in the AWS documentation - https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/high-throughput-fifo.html#enable-high-throughput-fifo.Related issue(s)