feat: solace add per operation fields#237
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
CameronRushton
left a comment
CameronRushton
left a comment
There was a problem hiding this comment.
Thanks for this. A couple simple requests to address & thank you for volunteering to update spec-json-schemas as well.
solace/README.md
Outdated
| `destinations`|List of Destination Objects|Destination Objects are described next. | ||
| Field Name | Type | Description | ||
| ---|---------------------------------------------------------------------------------|--- | ||
| `bindingVersion`| String |The current version is 0.3.0 |
There was a problem hiding this comment.
Please update the binding version to 0.4.0 throughout the document.
solace/README.md
Outdated
| `timeToLive` | Integer \| [Schema Object][schemaObject] \| [Reference Object](referenceObject) | Interval in milliseconds or a *Schema Object* containing the definition of the lifetime of the message. | ||
| `priority` | Integer \| [Schema Object][schemaObject] \| [Reference Object](referenceObject) | The valid priority value range is 0-255 with 0 as the lowest priority and 255 as the highest or a *Schema Object* containing the definition of the priority. |
There was a problem hiding this comment.
[Schema Object][schemaObject] | Reference Object
This appears to be broken. I think for v3, it's supposed to go here for referenceObject (https://www.asyncapi.com/docs/reference/specification/v3.0.0#referenceObject). Similarly for schemaObject.
There was a problem hiding this comment.
thanks for pointing out. i missed to links. Added it at the bottom.
GreenRover
force-pushed
the
feature/solace_ttl
branch
from
6b00275 to
4ac2f06
Compare
|
I changed example to async api 3.0 in same pr to avoid a version incretion to 0.5.0 for that |
CameronRushton
left a comment
CameronRushton
left a comment
There was a problem hiding this comment.
Looks great. We really appreciate your help!
|
/rtm |
3 participants
Description
To enable to documentate what the a good valid related to the business logic of this event. For example if a temperature reading is publish every 30 sec. A ttl >30sec would make no sense.
I choose a per operation bases to align to https://github.com/asyncapi/bindings/blob/master/mqtt/README.md
To enable to documentate the importent ratings of events.
To enable a message consumer to provide all necessary Information how the expected messages should look like.