feat: remove -f flag from asyncapi start command#1638
feat: remove -f flag from asyncapi start command#1638asyncapi-bot merged 3 commits intoasyncapi:masterfrom
Conversation
|
derberg
left a comment
There was a problem hiding this comment.
it looks pretty good, although please take into account I'm not a maintainer here, so in depth review is needed from their side. I'm not involved here for some time, afaik you should not use console.log directly.
anyway, from code, without manual testing, I see you fulfilled requirements. I hope you did manual testing.
of course there is also a case of missing unit tests
|
/ptal |
|
@Amzani @Souvikns @AayushSaini101 @Shurtu-gal Please take a look at this PR. Thanks! 👋 |
|
|
After a brief look over the PR, I found the following:
|
|
as specified in linked issues, studio command works like this now:
|
|
Okay, makes sense. |
|
/rtm |



Description
Remove -f flag from asyncapi start command
asyncapi start command can now work without filename also
Fixes #1623
Case 1 Filename given in command by user.

Case 2 Filename not given in command by user but asyncapi.yaml default file is present in current working directory.

Case 3 Filename not given in command by user and asyncapi.yaml default file is not present in current working directory. Open studio with empty file.

Studio for Case 3
