Skip to content

feat: new release pipeline with trusted publishing#1920

Merged
Shurtu-gal merged 11 commits intoasyncapi:masterfrom
Shurtu-gal:release-pipeline
Dec 12, 2025
Merged

feat: new release pipeline with trusted publishing#1920
Shurtu-gal merged 11 commits intoasyncapi:masterfrom
Shurtu-gal:release-pipeline

Conversation

@Shurtu-gal
Copy link
Copy Markdown
Collaborator

@Shurtu-gal Shurtu-gal commented Dec 12, 2025

Description

  • Dependency on next.js removed. We now use next.js bundled with Studio.
  • Release pipeline fixed according to NPM releases back in town community#2175
  • React2Shell vulnerabilty fixed as well due to Studio using 14.2.35 version.

Breaking changes

Credits: Work and commits taken from #1902 (by @Kartikayy007)

Related issue(s)
Fixes #1864
Related to #1752

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 12, 2025

🦋 Changeset detected

Latest commit: df22cd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@AayushSaini101 AayushSaini101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from To Triage to Backlog in CLI - Kanban Dec 12, 2025
@Shurtu-gal Shurtu-gal merged commit b90a9b7 into asyncapi:master Dec 12, 2025
22 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in CLI - Kanban Dec 12, 2025
@Shurtu-gal Shurtu-gal deleted the release-pipeline branch December 12, 2025 17:21
@enricojonas
Copy link
Copy Markdown

@Shurtu-gal thanks for merging this. Will you create a release as well?

@Shurtu-gal
Copy link
Copy Markdown
Collaborator Author

We are trying to do a release, for 2 days. But trusted publishing doesn't seem to work.
https://github.com/asyncapi/cli/actions/runs/20229761477/job/58070162616

With generator its working but not cli. Still trying to check where it might be failing.

diff --git a/.github/workflows/release-with-changesets.yml b/../generator/.github/workflows/release-with-changesets.yml
index 62256df..80b854a 100644
--- a/.github/workflows/release-with-changesets.yml
+++ b/../generator/.github/workflows/release-with-changesets.yml
@@ -66,7 +66,7 @@ jobs:
         run: npm test --if-present
       - if: failure() # Only, on failure, send a message on the 94_bot-failing-ci slack channel
         name: Report workflow run status to Slack
-        uses: 8398a7/action-slack@fbd6aa58ba854a740e11a35d0df80cb5d12101d8 # v3.15.1
+        uses: 8398a7/action-slack@v3
         with:
           status: ${{ job.status }}
           fields: repo,action,workflow
@@ -96,9 +96,9 @@ jobs:
       - if: steps.packagejson.outputs.exists == 'true'
         name: Check package-lock version
         uses: asyncapi/.github/.github/actions/get-node-version-from-package-lock@master
-        id: lockversion
         with:
           node-version: ${{ vars.NODE_VERSION }}
+        id: lockversion
       - if: steps.packagejson.outputs.exists == 'true'
         name: Setup Node.js
         uses: actions/setup-node@v4
@@ -116,10 +116,10 @@ jobs:
       - if: steps.packagejson.outputs.exists == 'true'
         name: Publish to any of NPM, Github, and Docker Hub
         #this step has 2 goals, it is either identifying that there is changeset file created and then this action creates a PR with version bump that will trigger release - or if it sees there is no changeset, and there are versions changes in package.json files, it publish new versions to NPM is they are not there yet
-        uses: changesets/action@e0145edc7d9d8679003495b11f87bd8ef63c0cba # v1.5.3
+        uses: changesets/action@v1
         id: release
         with:
-          version: npm run bump:version
+          version: npx -p @changesets/cli@2.27.7 changeset version
           commit: "chore(release): release and bump versions of packages"
           title: "chore(release): release and bump versions of packages"
           publish: npx -p @changesets/cli@2.27.7 changeset publish
@@ -132,7 +132,7 @@ jobs:
           GIT_COMMITTER_EMAIL: info@asyncapi.io
       - if: failure() # Only, on failure, send a message on the 94_bot-failing-ci Slack channel
         name: Report workflow run status to Slack
-        uses: 8398a7/action-slack@fbd6aa58ba854a740e11a35d0df80cb5d12101d8 # v3.15.1
+        uses: 8398a7/action-slack@v3
         with:
           status: ${{ job.status }}
           fields: repo,action,workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Studio & Preview Failing w/ Next Error

4 participants