Skip to content

fix: prevent double-stringification of AsyncAPI string in archiver service (#2026)#2134

Open
useye wants to merge 1 commit intoasyncapi:masterfrom
useye:fix/issue-2026-archiver-stringify
Open

fix: prevent double-stringification of AsyncAPI string in archiver service (#2026)#2134
useye wants to merge 1 commit intoasyncapi:masterfrom
useye:fix/issue-2026-archiver-stringify

Conversation

@useye
Copy link
Copy Markdown

@useye useye commented Apr 22, 2026

Summary

In src/domains/services/archiver.service.ts, the appendAsyncAPIDocument method always called JSON.stringify(asyncapi) even when asyncapi was already a string. This caused valid AsyncAPI YAML/JSON strings to be double-serialized, resulting in invalid documents in the generated zip archive.

Fix

Changed appendAsyncAPIDocument to only stringify when the input is an object:

const content =
  typeof asyncapi === 'string' ? asyncapi : JSON.stringify(asyncapi);

Also updated the method signature to accept string | object instead of just string.

Related Issue

Fixes #2026

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2026

⚠️ No Changeset found

Latest commit: a19a992

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

[BUG] : AsyncAPI document is double-stringified in generated ZIP output

1 participant