fix: prevent double-stringification of AsyncAPI string in archiver service (#2026)#2134
Open
useye wants to merge 1 commit intoasyncapi:masterfrom
Open
fix: prevent double-stringification of AsyncAPI string in archiver service (#2026)#2134useye wants to merge 1 commit intoasyncapi:masterfrom
useye wants to merge 1 commit intoasyncapi:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
In
src/domains/services/archiver.service.ts, theappendAsyncAPIDocumentmethod always calledJSON.stringify(asyncapi)even whenasyncapiwas already a string. This caused valid AsyncAPI YAML/JSON strings to be double-serialized, resulting in invalid documents in the generated zip archive.Fix
Changed
appendAsyncAPIDocumentto only stringify when the input is an object:Also updated the method signature to accept
string | objectinstead of juststring.Related Issue
Fixes #2026