fix: remove duplicate AsyncAPI spec loading in fromTemplate command (fixes #2017)#2157
Open
gavin913427-hash wants to merge 2 commits intoasyncapi:masterfrom
Open
fix: remove duplicate AsyncAPI spec loading in fromTemplate command (fixes #2017)#2157gavin913427-hash wants to merge 2 commits intoasyncapi:masterfrom
gavin913427-hash wants to merge 2 commits intoasyncapi:masterfrom
Conversation
The fromTemplate command was loading the AsyncAPI file twice: 1. Via this.loadAsyncAPIInput(asyncapi) on line 60 2. Via load(asyncapi) on line 70 This caused duplicate disk I/O, parsing, and unnecessary memory usage. Fix: Reuse the result from loadAsyncAPIInput() instead of loading again. Fixes asyncapi#2017
gavin913427-hash
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: a6f6b61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove duplicate AsyncAPI specification loading in the
fromTemplatecommand.Why
The
fromTemplatecommand was loading the AsyncAPI file twice during execution:this.loadAsyncAPIInput(asyncapi)on line 60load(asyncapi)on line 70This caused:
How
loadAsyncAPIInput()instead of callingload()againload,ValidationError)loadAsyncAPIInput()method already handles error cases internallyChanges
src/apps/cli/commands/generate/fromTemplate.tsasyncapiInputforspecification, remove duplicateload()call and unused importsTesting
The command should work exactly as before, but faster for large spec files:
Fixes #2017