Skip to content

docs: update documentation for overrides#203

Merged
aayushmau5 merged 2 commits into
asyncapi:masterfrom
maxbaldanza:update-docs
Feb 28, 2025
Merged

docs: update documentation for overrides#203
aayushmau5 merged 2 commits into
asyncapi:masterfrom
maxbaldanza:update-docs

Conversation

@maxbaldanza
Copy link
Copy Markdown
Contributor

@maxbaldanza maxbaldanza commented Feb 18, 2025

Looking at the source code then it looks like the config value should be override rather then overrides so updating documentation to reflect that

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Looking at the source code then it looks like the config value should
be `override` rather then `overrides` so updating documentation to reflect
that
@maxbaldanza maxbaldanza changed the title docs: Update documentation for overrides docs: update documentation for overrides Feb 18, 2025
Copy link
Copy Markdown
Member

@aayushmau5 aayushmau5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, Good catch!
Thanks @maxbaldanza :)

@sonarqubecloud
Copy link
Copy Markdown

@aayushmau5 aayushmau5 merged commit 8210da5 into asyncapi:master Feb 28, 2025
@maxbaldanza maxbaldanza deleted the update-docs branch February 28, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants